guix refresh -u weird behaviour

guix refresh -u weird behaviour

[jgart]

Hi Guixers,

guix refresh -u does some weird stuff. See the git diff below.

Why did it remove the native inputs?

Do we have a bug report open for this? Is it intended behaviour? 

all best,

jgart

 (define-public python-faker
   (package
     (name "python-faker")
-    (version "15.0.0")
+    (version "19.6.2")
     (source (origin
               (method url-fetch)
               (uri (pypi-uri "Faker" version))
               (sha256
                (base32
-                "1yx3gsivisf8ls43v0fgzy4n5q9625xrp9fr9cb5gp3h6k9cfpr4"))))
+                "10yzgya59l5kkrdfzp9m06cb5sj05py077h18s545yxhaqsrbmfm"))))
     (build-system python-build-system)
     (arguments
      '(#:phases
@@ -19707,12 +19707,8 @@ (define-public python-faker
              (when tests?
                (invoke "python" "-m" "pytest" "-v")))))))
     (native-inputs
-     (list python-freezegun
-           python-pytest
-           python-random2
-           python-ukpostcodeparser
-           python-validators))
-    (propagated-inputs (list python-dateutil))
+     (list))
+    (propagated-inputs (list python-dateutil python-typing-extensions))
     (home-page "https://github.com/joke2k/faker")
     (synopsis "Python package that generates fake data")

Re: guix refresh -u weird behaviour

[Ricardo Wurmus]

"jgart" <jgart@dismail.de> writes:

> guix refresh -u does some weird stuff. See the git diff below.
>
> Why did it remove the native inputs?

Because Faker doesn’t list them in a way that the importer can add them.
The quality of the importer determines the quality of the updater.  The
updater only does what the importer tells it to do.

-- 
Ricardo

Re: guix refresh -u weird behaviour

[Simon Tournier]

Hi jgart,

On Wed, 04 Oct 2023 at 10:10, Ricardo Wurmus <rekado@elephly.net> wrote:

> Because Faker doesn’t list them in a way that the importer can add them.
> The quality of the importer determines the quality of the updater.  The
> updater only does what the importer tells it to do.

…and the Guix importer tells what it reads from upstream. :-)

In the paragraph above, “Faker” means the JSON metadata that PyPI
provides.

One might be interested by this thread:

        Accuracy of importers?
        Ludovic Courtès <ludovic.courtes@inria.fr>
        Thu, 28 Oct 2021 09:02:27 +0200
        id:878ryd8we4.fsf@inria.fr
        https://lists.gnu.org/archive/html/guix-devel/2021-10
        https://yhetil.org/guix/878ryd8we4.fsf@inria.fr

Or by this message which provides some stats:

        Re: guix melpa mirror!
        zimoun <zimon.toutoune@gmail.com>
        Fri, 18 Nov 2022 09:20:25 +0100
        id:86cz9kk71y.fsf@gmail.com
        https://lists.gnu.org/archive/html/guix-devel/2022-11
        https://yhetil.org/guix/86cz9kk71y.fsf@gmail.com

Cheers,
simon

Re: guix refresh -u weird behaviour

[jgart]

> Because Faker doesn’t list them in a way that the importer can add them.

Hi Ricardo,

What is the way that Faker needs to list them?

I've experienced this same issue with quite a number of Python packages that I've tried to import though...

I'm just reporting Faker as one example to demonstrate the issue.

all best,

jgart

Re: guix refresh -u weird behaviour

[Ricardo Wurmus]

"jgart" <jgart@dismail.de> writes:

> I've experienced this same issue with quite a number of Python
> packages that I've tried to import though...

Yes, this indicates a defect in the importer.

-- 
Ricardo