Re: [PATCH] Add IBus.

[ludo@gnu.org (Ludovic Courtès)]

Ricardo Wurmus <rekado@elephly.net> skribis:

> From 63b0b09420decc5ee898ad313f602849ad57cfe8 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <rekado@elephly.net>
> Date: Mon, 16 Mar 2015 07:50:32 +0100
> Subject: [PATCH 1/3] gnu: python-pygobject: use home page of 3.x series.
>
> * gnu/packages/glib.scm (python-pygobject)[home-page]: Use home page of the
>   3.x series of the pygobject bindings instead of the home page for the 2.x
>   bindings.

OK.

> From e0493912a049714d6768391149e25e2233043ee6 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <rekado@elephly.net>
> Date: Mon, 16 Mar 2015 07:52:40 +0100
> Subject: [PATCH 2/3] gnu: Add python2-pygobject.
>
> * gnu/packages/glib.scm (python2-pygobject): New variable.

OK.

> From 28659b408990d41259c4eeb1302f593d5a44f638 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <rekado@elephly.net>
> Date: Mon, 16 Mar 2015 07:54:13 +0100
> Subject: [PATCH 3/3] gnu: Add IBus.
>
> * gnu/packages/ibus.scm: New file.
> * gnu-system.am (GNU_SYSTEM_MODULES): Add it.

[...]

> +        (lambda* (#:key inputs outputs #:allow-other-keys)
> +          ;; Make sure 'ibus-setup' runs with the correct PYTHONPATH and
> +          ;; GI_TYPELIB_PATH.
> +          (let ((out (assoc-ref outputs "out")))
> +            (substitute* (string-append out "/bin/.ibus-setup-real")
> +              (("exec ")
> +               (string-append "export PYTHONPATH=\""
> +                              (getenv "PYTHONPATH")
> +                              "${PYTHONPATH:+:}$PYTHONPATH" "\"\n"
> +                              "export GI_TYPELIB_PATH=\""
> +                              (getenv "GI_TYPELIB_PATH")
> +                              ":" out "/lib/girepository-1.0"
> +                              "${GI_TYPELIB_PATH:+:}$GI_TYPELIB_PATH"
> +                              "\"\n"
> +                              "\nexec ")))

I think it’s fine to use ‘wrap-program’ here, even if that means that
there’s an additional wrapper layer.

Unless there are performance concerns or similar, I think we should
favor readability and maintainability.

> +   (synopsis "Intelligent input bus")

Rather “Input method framework” (“intelligent” is meaningless.)

> +   (description
> +    "IBus means Intelligent Input Bus and is an input framework.")

What about:

  IBus is an input framework providing a full-featured and user-friendly
  input method user interface.  It comes with multilingual input
  support.  It may also simplify input method development.

Thanks,
Ludo’.