From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] Add IBus.
Date: Tue, 17 Mar 2015 10:04:10 +0100
Message-ID: <87y4mwov05.fsf@gnu.org>
References: <8761a1bejx.fsf@mango.localdomain>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35721)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1YXnQB-0005XZ-QF
	for guix-devel@gnu.org; Tue, 17 Mar 2015 05:04:20 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1YXnQ7-00053R-Iw
	for guix-devel@gnu.org; Tue, 17 Mar 2015 05:04:18 -0400
Received: from fencepost.gnu.org ([2001:4830:134:3::e]:35302)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1YXnQ7-00053N-GA
	for guix-devel@gnu.org; Tue, 17 Mar 2015 05:04:15 -0400
In-Reply-To: <8761a1bejx.fsf@mango.localdomain> (Ricardo Wurmus's message of
	"Mon, 16 Mar 2015 08:13:22 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Ricardo Wurmus <rekado@elephly.net>
Cc: Guix-devel <guix-devel@gnu.org>

Ricardo Wurmus <rekado@elephly.net> skribis:

> From 63b0b09420decc5ee898ad313f602849ad57cfe8 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <rekado@elephly.net>
> Date: Mon, 16 Mar 2015 07:50:32 +0100
> Subject: [PATCH 1/3] gnu: python-pygobject: use home page of 3.x series.
>
> * gnu/packages/glib.scm (python-pygobject)[home-page]: Use home page of t=
he
>   3.x series of the pygobject bindings instead of the home page for the 2=
.x
>   bindings.

OK.

> From e0493912a049714d6768391149e25e2233043ee6 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <rekado@elephly.net>
> Date: Mon, 16 Mar 2015 07:52:40 +0100
> Subject: [PATCH 2/3] gnu: Add python2-pygobject.
>
> * gnu/packages/glib.scm (python2-pygobject): New variable.

OK.

> From 28659b408990d41259c4eeb1302f593d5a44f638 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <rekado@elephly.net>
> Date: Mon, 16 Mar 2015 07:54:13 +0100
> Subject: [PATCH 3/3] gnu: Add IBus.
>
> * gnu/packages/ibus.scm: New file.
> * gnu-system.am (GNU_SYSTEM_MODULES): Add it.

[...]

> +        (lambda* (#:key inputs outputs #:allow-other-keys)
> +          ;; Make sure 'ibus-setup' runs with the correct PYTHONPATH and
> +          ;; GI_TYPELIB_PATH.
> +          (let ((out (assoc-ref outputs "out")))
> +            (substitute* (string-append out "/bin/.ibus-setup-real")
> +              (("exec ")
> +               (string-append "export PYTHONPATH=3D\""
> +                              (getenv "PYTHONPATH")
> +                              "${PYTHONPATH:+:}$PYTHONPATH" "\"\n"
> +                              "export GI_TYPELIB_PATH=3D\""
> +                              (getenv "GI_TYPELIB_PATH")
> +                              ":" out "/lib/girepository-1.0"
> +                              "${GI_TYPELIB_PATH:+:}$GI_TYPELIB_PATH"
> +                              "\"\n"
> +                              "\nexec ")))

I think it=E2=80=99s fine to use =E2=80=98wrap-program=E2=80=99 here, even =
if that means that
there=E2=80=99s an additional wrapper layer.

Unless there are performance concerns or similar, I think we should
favor readability and maintainability.

> +   (synopsis "Intelligent input bus")

Rather =E2=80=9CInput method framework=E2=80=9D (=E2=80=9Cintelligent=E2=80=
=9D is meaningless.)

> +   (description
> +    "IBus means Intelligent Input Bus and is an input framework.")

What about:

  IBus is an input framework providing a full-featured and user-friendly
  input method user interface.  It comes with multilingual input
  support.  It may also simplify input method development.

Thanks,
Ludo=E2=80=99.