unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
* [PATCH] gnu: qemu: Install all required info files.
@ 2016-11-23 20:50 Alex Kost
  2016-11-24  8:50 ` Chris Marusich
  0 siblings, 1 reply; 4+ messages in thread
From: Alex Kost @ 2016-11-23 20:50 UTC (permalink / raw)
  To: guix-devel

[-- Attachment #1: Type: text/plain, Size: 489 bytes --]

The current info manual of QEMU "does not work": qemu package provides
"qemu-doc.info" but not "qemu-doc.info-1" and other "*.info-N" files.

I believe the attached patch should fix it, but I couldn't test it, as
when I tried to build qemu, it failed on the check phase.  I am confused
as qemu has recently been built successfully on hydra, and to be honest
I don't have a wish to investigate.  So if anyone would like to test if
this patch really fixes the info manual, please do it :-)


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-qemu-Install-all-required-info-files.patch --]
[-- Type: text/x-diff, Size: 1020 bytes --]

From 86851ad63ddf8586507606508011753838b1e715 Mon Sep 17 00:00:00 2001
From: Alex Kost <alezost@gmail.com>
Date: Wed, 23 Nov 2016 23:25:27 +0300
Subject: [PATCH] gnu: qemu: Install all required info files.

* gnu/packages/qemu.scm (qemu)[arguments]: Adjust 'install-info' phase
to find all info files (including "*.info-N").
---
 gnu/packages/qemu.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/qemu.scm b/gnu/packages/qemu.scm
index 3c48b7a..e429c04 100644
--- a/gnu/packages/qemu.scm
+++ b/gnu/packages/qemu.scm
@@ -119,7 +119,7 @@
                         (let ((infodir (string-append out "/share/info")))
                           (for-each (lambda (info)
                                       (install-file info infodir))
-                                    (find-files "." "\\.info$"))
+                                    (find-files "." "\\.info"))
                           #t))))))
          (add-before 'check 'make-gtester-verbose
            (lambda _
-- 
2.10.2


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] gnu: qemu: Install all required info files.
  2016-11-23 20:50 [PATCH] gnu: qemu: Install all required info files Alex Kost
@ 2016-11-24  8:50 ` Chris Marusich
  2016-11-24 16:11   ` Ludovic Courtès
  0 siblings, 1 reply; 4+ messages in thread
From: Chris Marusich @ 2016-11-24  8:50 UTC (permalink / raw)
  To: Alex Kost; +Cc: guix-devel

[-- Attachment #1: Type: text/plain, Size: 712 bytes --]

Alex Kost <alezost@gmail.com> writes:

> The current info manual of QEMU "does not work": qemu package provides
> "qemu-doc.info" but not "qemu-doc.info-1" and other "*.info-N" files.
>
> I believe the attached patch should fix it, but I couldn't test it, as
> when I tried to build qemu, it failed on the check phase.  I am confused
> as qemu has recently been built successfully on hydra, and to be honest
> I don't have a wish to investigate.  So if anyone would like to test if
> this patch really fixes the info manual, please do it :-)

This patch works for me.  I built qemu successfully using it.  The info
docs are present now, and they were missing before.  I'd say ship it!

-- 
Chris

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] gnu: qemu: Install all required info files.
  2016-11-24  8:50 ` Chris Marusich
@ 2016-11-24 16:11   ` Ludovic Courtès
  2016-11-25 13:12     ` Alex Kost
  0 siblings, 1 reply; 4+ messages in thread
From: Ludovic Courtès @ 2016-11-24 16:11 UTC (permalink / raw)
  To: Chris Marusich; +Cc: guix-devel, Alex Kost

Chris Marusich <cmmarusich@gmail.com> skribis:

> Alex Kost <alezost@gmail.com> writes:
>
>> The current info manual of QEMU "does not work": qemu package provides
>> "qemu-doc.info" but not "qemu-doc.info-1" and other "*.info-N" files.
>>
>> I believe the attached patch should fix it, but I couldn't test it, as
>> when I tried to build qemu, it failed on the check phase.  I am confused
>> as qemu has recently been built successfully on hydra, and to be honest
>> I don't have a wish to investigate.  So if anyone would like to test if
>> this patch really fixes the info manual, please do it :-)
>
> This patch works for me.  I built qemu successfully using it.  The info
> docs are present now, and they were missing before.  I'd say ship it!

+1!

Ludo'.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] gnu: qemu: Install all required info files.
  2016-11-24 16:11   ` Ludovic Courtès
@ 2016-11-25 13:12     ` Alex Kost
  0 siblings, 0 replies; 4+ messages in thread
From: Alex Kost @ 2016-11-25 13:12 UTC (permalink / raw)
  To: guix-devel


> Chris Marusich <cmmarusich@gmail.com> skribis:
>
>> Alex Kost <alezost@gmail.com> writes:
>>
>>> The current info manual of QEMU "does not work": qemu package provides
>>> "qemu-doc.info" but not "qemu-doc.info-1" and other "*.info-N" files.
>>>
>>> I believe the attached patch should fix it, but I couldn't test it, as
>>> when I tried to build qemu, it failed on the check phase.  I am confused
>>> as qemu has recently been built successfully on hydra, and to be honest
>>> I don't have a wish to investigate.  So if anyone would like to test if
>>> this patch really fixes the info manual, please do it :-)
>>
>> This patch works for me.  I built qemu successfully using it.  The info
>> docs are present now, and they were missing before.  I'd say ship it!

Thanks for checking!  Pushed.  (I guessed it should work, it's just that
my computer is not powerful enough to build some packages.)

-- 
Alex

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2016-11-25 13:13 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-23 20:50 [PATCH] gnu: qemu: Install all required info files Alex Kost
2016-11-24  8:50 ` Chris Marusich
2016-11-24 16:11   ` Ludovic Courtès
2016-11-25 13:12     ` Alex Kost

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).