From: ludo@gnu.org (Ludovic Courtès)
To: Leo Famulari <leo@famulari.name>
Cc: guix-devel@gnu.org
Subject: Re: Running the full MariaDB test suite
Date: Thu, 26 Jul 2018 15:21:08 +0200 [thread overview]
Message-ID: <87y3dyyvy3.fsf@gnu.org> (raw)
In-Reply-To: <20180717214708.GA32734@jasmine.lan> (Leo Famulari's message of "Tue, 17 Jul 2018 17:47:08 -0400")
Leo Famulari <leo@famulari.name> skribis:
> On Tue, Jul 17, 2018 at 10:04:42PM +0200, Marius Bakke wrote:
>> Hello!
>>
>> So far our MariaDB package has only run some very lightweight tests.
>> 10.1.34 flipped a switch that runs the entire "MTR" test suite.
>>
>> After patching /bin/ls and /bin/sh, and fixing a couple of failures that
>> showed up after about 4 hours each, the most recent attempt took eight
>> hours during which my SSD was completely thrashed. And then it failed a
>> test case related to the "disks" plugin.
>>
>> The switch was flipped back shortly after the release:
>>
>> https://github.com/MariaDB/server/commit/0a9d78f51d74be7708f2efd940311bf7b33108e9
>>
>> Since 10.1.35 won't run these tests anymore, we could skip them for this
>> release and don't care about it.
>>
>> Alternatively, we can replace the 'check' phase with something that
>> invokes "mtr" with sensible arguments, and passing our own list of tests
>> to skip. That is what Debian does:
>>
>> https://salsa.debian.org/mariadb-team/mariadb-10.1/blob/stretch/debian/rules#L96
>>
>> Thoughts?
>>
>> I'm leaning towards the latter approach, since I've already spent
>> considerable time tracking down related failures, and it already
>> identified a potential problem in the "disks" plugin. But it means
>> building MariaDB will take many hours even on powerful machines.
>
> No strong opinion but the latter approach sounds good to me.
Same here.
Great that you spent energy tracking these issues!
Ludo’.
prev parent reply other threads:[~2018-07-26 13:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-17 20:04 Running the full MariaDB test suite Marius Bakke
2018-07-17 21:47 ` Leo Famulari
2018-07-26 13:21 ` Ludovic Courtès [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y3dyyvy3.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
--cc=leo@famulari.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).