From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: Running the full MariaDB test suite
Date: Thu, 26 Jul 2018 15:21:08 +0200
Message-ID: <87y3dyyvy3.fsf@gnu.org>
References: <87o9f56339.fsf@fastmail.com> <20180717214708.GA32734@jasmine.lan>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49315)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1figCg-0002Tm-SC
	for guix-devel@gnu.org; Thu, 26 Jul 2018 09:21:17 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1figCd-00069p-SC
	for guix-devel@gnu.org; Thu, 26 Jul 2018 09:21:14 -0400
In-Reply-To: <20180717214708.GA32734@jasmine.lan> (Leo Famulari's message of
	"Tue, 17 Jul 2018 17:47:08 -0400")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Leo Famulari <leo@famulari.name>
Cc: guix-devel@gnu.org

Leo Famulari <leo@famulari.name> skribis:

> On Tue, Jul 17, 2018 at 10:04:42PM +0200, Marius Bakke wrote:
>> Hello!
>>=20
>> So far our MariaDB package has only run some very lightweight tests.
>> 10.1.34 flipped a switch that runs the entire "MTR" test suite.
>>=20
>> After patching /bin/ls and /bin/sh, and fixing a couple of failures that
>> showed up after about 4 hours each, the most recent attempt took eight
>> hours during which my SSD was completely thrashed.  And then it failed a
>> test case related to the "disks" plugin.
>>=20
>> The switch was flipped back shortly after the release:
>>=20
>> https://github.com/MariaDB/server/commit/0a9d78f51d74be7708f2efd940311bf=
7b33108e9
>>=20
>> Since 10.1.35 won't run these tests anymore, we could skip them for this
>> release and don't care about it.
>>=20
>> Alternatively, we can replace the 'check' phase with something that
>> invokes "mtr" with sensible arguments, and passing our own list of tests
>> to skip.  That is what Debian does:
>>=20
>> https://salsa.debian.org/mariadb-team/mariadb-10.1/blob/stretch/debian/r=
ules#L96
>>=20
>> Thoughts?
>>=20
>> I'm leaning towards the latter approach, since I've already spent
>> considerable time tracking down related failures, and it already
>> identified a potential problem in the "disks" plugin.  But it means
>> building MariaDB will take many hours even on powerful machines.
>
> No strong opinion but the latter approach sounds good to me.

Same here.

Great that you spent energy tracking these issues!

Ludo=E2=80=99.