Re: 01/01: Merge branch 'staging'

Re: 01/01: Merge branch 'staging'

[Mark H Weaver]

Hi Ludovic,

guix-commits@gnu.org writes:

> civodul pushed a commit to branch master
> in repository guix.
>
> commit 50a93adc05b611836e740c4b55571890f4c6770a
> Merge: 722ac64 69fb26d
> Author: Ludovic Courtès <ludo@gnu.org>
> Date:   Sat Feb 9 15:14:59 2019 +0100
>
>     Merge branch 'staging'

I asked Hydra to evaluate 'master' after this commit, and it failed.
See below for the evaluator.log output.

I was a little surprised to see this merge, given that Hydra hasn't
evaluated the 'staging' branch since December.

       Mark


--8<---------------cut here---------------start------------->8---
considering jobset gnu:master (last checked 26319s ago)
checking out Git branch master from https://git.savannah.gnu.org/r/guix.git
Initialized empty Git repository in /tmp/git-checkout-tmp-32294/git-export/.git/
From /var/lib/hydra/scm/git/f08e53b7f0f3ce68a74e8745c37add3d0aecabda3e30c724b0d838fdc6743e2b
 * branch            master     -> FETCH_HEAD
 * [new branch]      master     -> origin/master
Switched to a new branch 'fetchgit'
removing `.git'...
hash is d8d3fcec5856ad4fd023f6d1dbc962d3e207afed4b62ce6470c41f756cf22826
path is /gnu/store/1mkv0pa3yfgb8zvyc8lv3rgbppa313xw-git-export
evaluator hydra-eval-guile-jobs
hydra-eval-guile-jobs returned exit code 1:
adding `/gnu/store/1mkv0pa3yfgb8zvyc8lv3rgbppa313xw-git-export' to the load path
WARNING: (gnu packages emacs-xyz): `python-sphinx' imported from both (gnu packages python) and (gnu packages python-xyz)
WARNING: (gnu packages emacs-xyz): `python-autopep8' imported from both (gnu packages python) and (gnu packages python-xyz)
WARNING: (gnu packages emacs-xyz): `python-black' imported from both (gnu packages python) and (gnu packages python-xyz)
WARNING: (gnu packages emacs-xyz): `python-flake8' imported from both (gnu packages python) and (gnu packages python-xyz)
WARNING: (gnu packages emacs-xyz): `python-jedi' imported from both (gnu packages python) and (gnu packages python-xyz)
WARNING: (gnu packages emacs-xyz): `python-yapf' imported from both (gnu packages python) and (gnu packages python-xyz)
WARNING: (gnu packages guile-xyz): `sqlite' imported from both (gnu packages databases) and (gnu packages sqlite)
WARNING: (gnu packages python-compression): `python-setuptools-scm' imported from both (gnu packages python) and (gnu packages python-xyz)
WARNING: (gnu packages python-compression): `python-future' imported from both (gnu packages python) and (gnu packages python-xyz)
WARNING: (gnu packages python-compression): `python-numpy' imported from both (gnu packages python) and (gnu packages python-xyz)
WARNING: (gnu packages python-compression): `python-h5py' imported from both (gnu packages python) and (gnu packages python-xyz)
WARNING: (gnu packages python-compression): `python-cython' imported from both (gnu packages python) and (gnu packages python-xyz)
WARNING: (gnu packages sagemath): `python-cython' imported from both (gnu packages python) and (gnu packages python-xyz)
WARNING: (gnu packages sagemath): `python-cysignals' imported from both (gnu packages python) and (gnu packages python-xyz)
Backtrace:
In ice-9/eval.scm:
    619:8 19 (_ #(#(#<directory (guile-user) 1b5d140>)))
In ice-9/command-line.scm:
   181:18 18 (_ #<input: string 1b978c0>)
In unknown file:
          17 (eval (apply (module-ref (resolve-interface (?)) #) #) #)
In /usr/local/bin/hydra-eval-guile-jobs:
   244:18 16 (eval-guile-jobs . _)
In ice-9/eval.scm:
    619:8 15 (_ #(#(#(#<module (#{ g23}#) 1b913c0>) #<build-da?> ?) ?))
   626:19 14 (_ #(#(#(#<module (#{ g23}#) 1b913c0>) #<build-da?> ?) ?))
In guix/store.scm:
  1698:24 13 (run-with-store _ _ #:guile-for-build _ #:system _ # _)
In guix/channels.scm:
    402:2 12 (_ _)
    394:2 11 (_ _)
    310:2 10 (_ _)
In unknown file:
           9 (_ #<procedure 20dc280 at ice-9/eval.scm:330:13 ()> #<?> ?)
In guix/gexp.scm:
    702:2  8 (_ _)
In guix/monads.scm:
    471:9  7 (_ _)
In guix/gexp.scm:
   572:13  6 (_ _)
In guix/store.scm:
   1571:8  5 (_ _)
  1594:38  4 (_ #<build-daemon 256.97 664fc80>)
In guix/packages.scm:
   873:16  3 (cache! #<weak-table 307/443> #<package guile-gcrypt@0?> ?)
  1195:22  2 (thunk)
  1128:25  1 (bag->derivation #<build-daemon 256.97 664fc80> #<<bag?> ?)
In srfi/srfi-1.scm:
   592:17  0 (map1 (("source" #<origin #<<git-reference> url: "?>) ?))

srfi/srfi-1.scm:592:17: In procedure map1:
Throw to key `srfi-34' with args `(#<condition &message [message: "ghostscript-CVE-2018-16509.patch: patch not found"] 42fd960>)'.

Some deprecated features have been used.  Set the environment
variable GUILE_WARN_DEPRECATED to "detailed" and rerun the
program to get more information.  Set it to "no" to suppress
this message.
--8<---------------cut here---------------end--------------->8---

Re: 01/01: Merge branch 'staging'

[Jan Nieuwenhuizen]

Mark H Weaver writes:

Hi Mark, Ludo',

>> commit 50a93adc05b611836e740c4b55571890f4c6770a
>> Merge: 722ac64 69fb26d
>> Author: Ludovic Courtès <ludo@gnu.org>
>> Date:   Sat Feb 9 15:14:59 2019 +0100
>>
>>     Merge branch 'staging'
>
> I asked Hydra to evaluate 'master' after this commit, and it failed.
> See below for the evaluator.log output.

I tried to reproduce this, by building ghostscript locally, but failed.

Then I noticed that this string

> srfi/srfi-1.scm:592:17: In procedure map1:
> Throw to key `srfi-34' with args `(#<condition &message [message:
> "ghostscript-CVE-2018-16509.patch: patch not found"] 42fd960>)'.

does not exist in master

--8<---------------cut here---------------start------------->8---
18:51:24 janneke@dundal:~/src/guix/master 
$ git show HEAD | head -2
commit 50a93adc05b611836e740c4b55571890f4c6770a
Merge: 722ac64cd7 69fb26d4f5
18:51:52 janneke@dundal:~/src/guix/master 
$ git grep ghostscript-CVE-2018-16509.patch
[1]18:51:56 janneke@dundal:~/src/guix/master 
--8<---------------cut here---------------end--------------->8---

...what's going on?

janneke

-- 
Jan Nieuwenhuizen <janneke@gnu.org> | GNU LilyPond http://lilypond.org
Freelance IT http://JoyofSource.com | Avatar® http://AvatarAcademy.com

Re: 01/01: Merge branch 'staging'

[Ludovic Courtès]

[-- Attachment #1: Type: text/plain, Size: 1478 bytes --]

Hi Mark,

Mark H Weaver <mhw@netris.org> skribis:

> guix-commits@gnu.org writes:
>
>> civodul pushed a commit to branch master
>> in repository guix.
>>
>> commit 50a93adc05b611836e740c4b55571890f4c6770a
>> Merge: 722ac64 69fb26d
>> Author: Ludovic Courtès <ludo@gnu.org>
>> Date:   Sat Feb 9 15:14:59 2019 +0100
>>
>>     Merge branch 'staging'
>
> I asked Hydra to evaluate 'master' after this commit, and it failed.
> See below for the evaluator.log output.

[...]

> evaluator hydra-eval-guile-jobs
> hydra-eval-guile-jobs returned exit code 1:
> adding `/gnu/store/1mkv0pa3yfgb8zvyc8lv3rgbppa313xw-git-export' to the load path
> WARNING: (gnu packages emacs-xyz): `python-sphinx' imported from both (gnu packages python) and (gnu packages python-xyz)
> WARNING: (gnu packages emacs-xyz): `python-autopep8' imported from both (gnu packages python) and (gnu packages python-xyz)

[...]

> Throw to key `srfi-34' with args `(#<condition &message [message: "ghostscript-CVE-2018-16509.patch: patch not found"] 42fd960>)'.

The problem is that ‘hydra-eval-guile-jobs’ would systematically add its
inputs to ‘%load-path’.  Chaos ensues, because we end up loading a
mixture of modules from the checkout and modules from the installed Guix
(that’s why we used to force auto-compilation, before commit
b5f8c2c88543158e8aca76aa98f9009f6b9e743a.)

To address this, I locally modified ‘hydra-eval-guile-jobs’ along these
lines:


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 800 bytes --]

diff --git a/src/script/hydra-eval-guile-jobs.in b/src/script/hydra-eval-guile-jobs.in
index 8c5df125..788f0786 100644
--- a/src/script/hydra-eval-guile-jobs.in
+++ b/src/script/hydra-eval-guile-jobs.in
@@ -192,9 +192,7 @@ directory or #f."
                       ((_ dir) dir)
                       ((dir)   dir)))
               (dir* (module-directory dir)))
-         (format (current-error-port) "adding `~a' to the load path~%" dir*)
-        (set! %load-path (cons dir* %load-path))
-        (set! %load-compiled-path (cons dir* %load-compiled-path)))
+         (format (current-error-port) "NOT adding `~a' to the load path~%" dir*))
        (loop rest result file entry roots-dir))
       (("--argstr" name value rest ...)
        (loop rest (alist-cons (string->symbol name) value result)

[-- Attachment #3: Type: text/plain, Size: 280 bytes --]


That solved the issue:

  https://hydra.gnu.org/jobset/gnu/master

However, relying on this customized variant of an old Hydra isn’t really
viable IMO.  We should consider switching hydra.gnu.org to a config
similar to that of berlin and bayfront.

Thanks,
Ludo’.