unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: guix-devel@gnu.org, Kei Kebreau <kkebreau@posteo.net>
Subject: Re: 02/05: gnu: libmad: Install pkg-config file.
Date: Mon, 04 Jan 2021 12:31:54 +0100	[thread overview]
Message-ID: <87y2h9uedx.fsf@gnu.org> (raw)
In-Reply-To: <20201227214244.B3AE12094A@vcs0.savannah.gnu.org> (guix-commits@gnu.org's message of "Sun, 27 Dec 2020 16:42:44 -0500 (EST)")

Hi Kei,

guix-commits@gnu.org skribis:

> commit 83afa4e9a6aa4dc69f86651d795007dc96a31e64
> Author: Kei Kebreau <kkebreau@posteo.net>
> AuthorDate: Sun Aug 2 16:54:03 2020 -0400
>
>     gnu: libmad: Install pkg-config file.
>     
>     * gnu/packages/mp3.scm (libmad)[arguments]: Add 'install-pkg-config phase.

[...]

> +        (add-after 'install 'install-pkg-config
> +          (lambda* (#:key outputs #:allow-other-keys)
> +            (let* ((out (assoc-ref outputs "out"))
> +                   (pkg-config-dir (string-append out "/lib/pkgconfig")))
> +              (mkdir-p pkg-config-dir)
> +              (with-output-to-file (string-append pkg-config-dir "/mad.pc")
> +                (lambda _
> +                  (format #t
> +                          "prefix=~@*~a~@
> +                           libdir=${prefix}/lib~@

It seems to me that we shouldn’t provide .pc files if upstream doesn’t
do it.  The main reason is that developers who use Guix will come to
rely on it and unknowingly write code that doesn’t work on other
distros.  (I remember pestering in the past as I stumbled upon packages
who depended on some library as packaged by a specific distro.  :-))

WDYT?

Apologies if I missed an earlier discussion!

Ludo’.


       reply	other threads:[~2021-01-04 11:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20201227214242.9652.34624@vcs0.savannah.gnu.org>
     [not found] ` <20201227214244.B3AE12094A@vcs0.savannah.gnu.org>
2021-01-04 11:31   ` Ludovic Courtès [this message]
2021-01-04 18:12     ` 02/05: gnu: libmad: Install pkg-config file Kei
2021-01-06 11:11       ` Ludovic Courtès
2021-01-06 17:49         ` Kei Kebreau
2021-01-14 21:34           ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y2h9uedx.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=guix-devel@gnu.org \
    --cc=kkebreau@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).