unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Kei <kkebreau@posteo.net>
To: "Ludovic Courtès" <ludo@gnu.org>, guix-devel@gnu.org
Subject: Re: 02/05: gnu: libmad: Install pkg-config file.
Date: Mon, 04 Jan 2021 13:12:54 -0500	[thread overview]
Message-ID: <7e293c9b63126f4569ac158678ca08405683e7ee.camel@posteo.net> (raw)
In-Reply-To: <87y2h9uedx.fsf@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 1474 bytes --]

Hi Ludovic,

> It seems to me that we shouldn’t provide .pc files if upstream doesn’t
> do it.  The main reason is that developers who use Guix will come to
> rely on it and unknowingly write code that doesn’t work on other
> distros.  (I remember pestering in the past as I stumbled upon packages
> who depended on some library as packaged by a specific distro.  :-))
> 
> WDYT?
> 
> Apologies if I missed an earlier discussion!

No apologies needed, the discussion was minimal at best.  This patch is the
result of my yielding to the forces of incompatibility you mention.  Major
distributions like Debian, Arch Linux [1], and Fedora [2] have all added pkg-
config files for (at least) libmad.  Audacity expects to find pkg-config files
for the system libraries it uses, so I supplied those to follow the path of
least resistance.

If there's a way to supply "-I" and "-L" flags directly somewhere in the build
process as was done before, I'm not opposed to reverting these changes and
modifying Audacity's package definition myself during the next update.  I'll
investigate some of our other CMake packages for possible inspiration.

Thanks,
Kei

[0]: https://packages.debian.org/buster/amd64/libmad0-dev/filelist
[1]: 
https://github.com/archlinux/svntogit-packages/blob/packages/libmad/trunk/libmad.patch
[2]: 
https://koji.fedoraproject.org/koji/rpminfo?fileOrder=-name&rpmID=22388610&buildrootOrder=-id&buildrootStart=0#filelist

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 862 bytes --]

  reply	other threads:[~2021-01-04 18:15 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20201227214242.9652.34624@vcs0.savannah.gnu.org>
     [not found] ` <20201227214244.B3AE12094A@vcs0.savannah.gnu.org>
2021-01-04 11:31   ` 02/05: gnu: libmad: Install pkg-config file Ludovic Courtès
2021-01-04 18:12     ` Kei [this message]
2021-01-06 11:11       ` Ludovic Courtès
2021-01-06 17:49         ` Kei Kebreau
2021-01-14 21:34           ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7e293c9b63126f4569ac158678ca08405683e7ee.camel@posteo.net \
    --to=kkebreau@posteo.net \
    --cc=guix-devel@gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).