From: "Ludovic Courtès" <ludo@gnu.org>
To: guix-devel@gnu.org, Chris Marusich <cmmarusich@gmail.com>
Subject: Re: 02/03: tests: gremlin: Skip file-needed/recursive if DT_NEEDED is empty.
Date: Wed, 24 Feb 2021 11:20:34 +0100 [thread overview]
Message-ID: <87y2fd3gy5.fsf@gnu.org> (raw)
In-Reply-To: <20210224094221.846A320536@vcs0.savannah.gnu.org> (guix-commits@gnu.org's message of "Wed, 24 Feb 2021 04:42:21 -0500 (EST)")
guix-commits@gnu.org skribis:
> +++ b/tests/gremlin.scm
> @@ -61,7 +61,12 @@
> (elf-dynamic-info-needed dyninfo))))))
>
> (unless (and %guile-executable (not (getenv "LD_LIBRARY_PATH"))
> - (file-needed %guile-executable)) ;statically linked?
> + (file-needed %guile-executable) ;statically linked?
> + ;; When Guix has been built on a foreign distro, using a
> + ;; toolchain and libraries from that foreign distro, it is not
> + ;; unusual for the runpath to be empty.
> + (and=> (file-runpath %guile-executable)
> + (compose not null-list?)))
Nitpick: you can write ‘pair?’ instead of ‘(compose …)’.
I guess the problem is that ‘file-needed/recursive’ only looks at
RUNPATH, ignoring the notion of “standard directories” like /usr/lib.
Ludo’.
next parent reply other threads:[~2021-02-24 10:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210224094215.22478.70281@vcs0.savannah.gnu.org>
[not found] ` <20210224094221.846A320536@vcs0.savannah.gnu.org>
2021-02-24 10:20 ` Ludovic Courtès [this message]
2021-02-24 17:34 ` 02/03: tests: gremlin: Skip file-needed/recursive if DT_NEEDED is empty Chris Marusich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y2fd3gy5.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=cmmarusich@gmail.com \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).