From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 4MvWE5soNmCIGQAA0tVLHw (envelope-from ) for ; Wed, 24 Feb 2021 10:21:15 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id eIawD5soNmAVIgAAbx9fmQ (envelope-from ) for ; Wed, 24 Feb 2021 10:21:15 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A9A37218DA for ; Wed, 24 Feb 2021 11:21:14 +0100 (CET) Received: from localhost ([::1]:53900 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lErI9-0005FE-CN for larch@yhetil.org; Wed, 24 Feb 2021 05:21:13 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:35558) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lErHa-0005F7-67 for guix-devel@gnu.org; Wed, 24 Feb 2021 05:20:38 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:59093) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lErHZ-0003xp-VK; Wed, 24 Feb 2021 05:20:37 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=33768 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lErHZ-0003Ci-6x; Wed, 24 Feb 2021 05:20:37 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: guix-devel@gnu.org, Chris Marusich Subject: Re: 02/03: tests: gremlin: Skip file-needed/recursive if DT_NEEDED is empty. References: <20210224094215.22478.70281@vcs0.savannah.gnu.org> <20210224094221.846A320536@vcs0.savannah.gnu.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 6 =?utf-8?Q?Vent=C3=B4se?= an 229 de la =?utf-8?Q?R?= =?utf-8?Q?=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Wed, 24 Feb 2021 11:20:34 +0100 In-Reply-To: <20210224094221.846A320536@vcs0.savannah.gnu.org> (guix-commits@gnu.org's message of "Wed, 24 Feb 2021 04:42:21 -0500 (EST)") Message-ID: <87y2fd3gy5.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -2.87 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Queue-Id: A9A37218DA X-Spam-Score: -2.87 X-Migadu-Scanner: scn1.migadu.com X-TUID: 5DbZXovZJY29 guix-commits@gnu.org skribis: > +++ b/tests/gremlin.scm > @@ -61,7 +61,12 @@ > (elf-dynamic-info-needed dyninfo)))))) >=20=20 > (unless (and %guile-executable (not (getenv "LD_LIBRARY_PATH")) > - (file-needed %guile-executable)) ;statically linked? > + (file-needed %guile-executable) ;statically linked? > + ;; When Guix has been built on a foreign distro, using a > + ;; toolchain and libraries from that foreign distro, it is = not > + ;; unusual for the runpath to be empty. > + (and=3D> (file-runpath %guile-executable) > + (compose not null-list?))) Nitpick: you can write =E2=80=98pair?=E2=80=99 instead of =E2=80=98(compose= =E2=80=A6)=E2=80=99. I guess the problem is that =E2=80=98file-needed/recursive=E2=80=99 only lo= oks at RUNPATH, ignoring the notion of =E2=80=9Cstandard directories=E2=80=9D like= /usr/lib. Ludo=E2=80=99.