unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] Add pbtranscript-tofu.
Date: Tue, 24 Mar 2015 10:23:16 +0100	[thread overview]
Message-ID: <87wq26g35n.fsf@gnu.org> (raw)
In-Reply-To: <idjk2ybdbj8.fsf@bimsb-sys02.mdc-berlin.net> (Ricardo Wurmus's message of "Fri, 20 Mar 2015 14:49:15 +0100")

Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> skribis:

> From 39f77a513b2505d2a9658f6f9ed40f24a6b93dfd Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
> Date: Wed, 18 Mar 2015 14:39:42 +0100
> Subject: [PATCH 1/2] gnu: Add python2-bx-python.
>
> * gnu/packages/bioinformatics.scm (python2-bx-python): New variable.

LGTM.

> From 42c865d2c29b7c68e81580de98997266112d6cd9 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
> Date: Fri, 20 Mar 2015 14:36:38 +0100
> Subject: [PATCH 2/2] gnu: Add pbtranscript-tofu.
>
> * gnu/packages/bioinformatics.scm (pbtranscript-tofu): New variable.

[...]

> +    (version "0.4.1-c7bbd5472")
> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "https://github.com/PacificBiosciences/cDNA_primer.git")
> +                    (commit "c7bbd54720df578777743d687ceaf6b4f6d4919e")))

To avoid mistakes in the future, I would do:

  (let ((commit "c7bbd5472"))
    (package
      (version (string-append "0.4.1." commit))
      (source (origin ...
                (commit commit)))
      ;; ...
      ))

Also, I think 0.4.1.c7bbd5472 is slightly nicer than 0.4.1-c7bbd5472.

Other than that LGTM.

Thanks!

Ludo’.

      reply	other threads:[~2015-03-24  9:23 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-20 13:49 [PATCH] Add pbtranscript-tofu Ricardo Wurmus
2015-03-24  9:23 ` Ludovic Courtès [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wq26g35n.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=guix-devel@gnu.org \
    --cc=ricardo.wurmus@mdc-berlin.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).