From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] Add pbtranscript-tofu.
Date: Tue, 24 Mar 2015 10:23:16 +0100
Message-ID: <87wq26g35n.fsf@gnu.org>
References: <idjk2ybdbj8.fsf@bimsb-sys02.mdc-berlin.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49170)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1YaL3R-0001hC-L3
	for guix-devel@gnu.org; Tue, 24 Mar 2015 05:23:22 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1YaL3O-0006r2-Vv
	for guix-devel@gnu.org; Tue, 24 Mar 2015 05:23:21 -0400
Received: from fencepost.gnu.org ([2001:4830:134:3::e]:45441)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1YaL3O-0006qy-Tp
	for guix-devel@gnu.org; Tue, 24 Mar 2015 05:23:18 -0400
In-Reply-To: <idjk2ybdbj8.fsf@bimsb-sys02.mdc-berlin.net> (Ricardo Wurmus's
	message of "Fri, 20 Mar 2015 14:49:15 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Cc: guix-devel@gnu.org

Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> skribis:

> From 39f77a513b2505d2a9658f6f9ed40f24a6b93dfd Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
> Date: Wed, 18 Mar 2015 14:39:42 +0100
> Subject: [PATCH 1/2] gnu: Add python2-bx-python.
>
> * gnu/packages/bioinformatics.scm (python2-bx-python): New variable.

LGTM.

> From 42c865d2c29b7c68e81580de98997266112d6cd9 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
> Date: Fri, 20 Mar 2015 14:36:38 +0100
> Subject: [PATCH 2/2] gnu: Add pbtranscript-tofu.
>
> * gnu/packages/bioinformatics.scm (pbtranscript-tofu): New variable.

[...]

> +    (version "0.4.1-c7bbd5472")
> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "https://github.com/PacificBiosciences/cDNA_pri=
mer.git")
> +                    (commit "c7bbd54720df578777743d687ceaf6b4f6d4919e")))

To avoid mistakes in the future, I would do:

  (let ((commit "c7bbd5472"))
    (package
      (version (string-append "0.4.1." commit))
      (source (origin ...
                (commit commit)))
      ;; ...
      ))

Also, I think 0.4.1.c7bbd5472 is slightly nicer than 0.4.1-c7bbd5472.

Other than that LGTM.

Thanks!

Ludo=E2=80=99.