From: ludo@gnu.org (Ludovic Courtès)
To: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH]: gnu: shogun: Remove non-free source files.
Date: Fri, 15 May 2015 18:56:12 +0200 [thread overview]
Message-ID: <87wq09wzir.fsf@gnu.org> (raw)
In-Reply-To: <idjwq09j35g.fsf@bimsb-sys02.mdc-berlin.net> (Ricardo Wurmus's message of "Fri, 15 May 2015 17:01:31 +0200")
Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> skribis:
>>>>> There are functions in src/shogun/kernel/Kernel.{cpp,h} that are also
>>>>> released under non-free terms, but they are enclosed in #ifdef
>>>>> statements and the make flags we pass disable these functions at build
>>>>> time.
>>>>
>>>> This is not sufficient. We will need to completely remove the non-free
>>>> functions from the source code using a snippet. We cannot use a patch
>>>> because the patch would contain the non-free code.
>
> Just a quick update: I've added snippets to remove all non-free stuff
> and it's compiling (after I applied a patch to R 3.2.0 which I will send
> to the ML later).
Great.
> Sadly, the RUNPATH validation is failing, so I first need to find some
> time to fix this. Would you like me to submit the patch to remove the
> non-free parts first even though the RUNPATH validation is still
> failing, or would you like me to submit this all at once instead?
If the two are unrelated, feel free to commit the snippets already.
Thanks,
Ludo’.
next prev parent reply other threads:[~2015-05-15 16:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-08 14:56 [PATCH]: gnu: shogun: Remove non-free source files Ricardo Wurmus
2015-05-08 17:30 ` Ludovic Courtès
2015-05-09 5:15 ` Mark H Weaver
2015-05-09 13:49 ` Ludovic Courtès
2015-05-09 16:41 ` Mark H Weaver
2015-05-15 15:01 ` Ricardo Wurmus
2015-05-15 16:56 ` Ludovic Courtès [this message]
2015-05-21 9:59 ` Ricardo Wurmus
2015-05-21 19:52 ` Ludovic Courtès
2015-05-21 19:55 ` Ludovic Courtès
2015-05-09 21:06 ` Ricardo Wurmus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wq09wzir.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
--cc=ricardo.wurmus@mdc-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).