From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH]: gnu: shogun: Remove non-free source files. Date: Fri, 15 May 2015 18:56:12 +0200 Message-ID: <87wq09wzir.fsf@gnu.org> References: <87a8xeqqk7.fsf@netris.org> <871tipj1xq.fsf@gnu.org> <87mw1dputa.fsf@netris.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:58487) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YtIuJ-0007pd-UE for guix-devel@gnu.org; Fri, 15 May 2015 12:56:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YtIuG-0000sS-02 for guix-devel@gnu.org; Fri, 15 May 2015 12:56:19 -0400 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:49759) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YtIuF-0000sO-TB for guix-devel@gnu.org; Fri, 15 May 2015 12:56:15 -0400 In-Reply-To: (Ricardo Wurmus's message of "Fri, 15 May 2015 17:01:31 +0200") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Ricardo Wurmus Cc: guix-devel Ricardo Wurmus skribis: >>>>> There are functions in src/shogun/kernel/Kernel.{cpp,h} that are also >>>>> released under non-free terms, but they are enclosed in #ifdef >>>>> statements and the make flags we pass disable these functions at build >>>>> time. >>>> >>>> This is not sufficient. We will need to completely remove the non-free >>>> functions from the source code using a snippet. We cannot use a patch >>>> because the patch would contain the non-free code. > > Just a quick update: I've added snippets to remove all non-free stuff > and it's compiling (after I applied a patch to R 3.2.0 which I will send > to the ML later). Great. > Sadly, the RUNPATH validation is failing, so I first need to find some > time to fix this. Would you like me to submit the patch to remove the > non-free parts first even though the RUNPATH validation is still > failing, or would you like me to submit this all at once instead? If the two are unrelated, feel free to commit the snippets already. Thanks, Ludo=E2=80=99.