* Re: 01/01: gnu: Add guile-curl.
[not found] ` <20180418210131.A20A7204F1@vcs0.savannah.gnu.org>
@ 2018-04-19 12:20 ` Mark H Weaver
2018-04-19 12:31 ` Roel Janssen
0 siblings, 1 reply; 2+ messages in thread
From: Mark H Weaver @ 2018-04-19 12:20 UTC (permalink / raw)
To: Roel Janssen; +Cc: guix-devel
Hi Roel,
roel@gnu.org (Roel Janssen) writes:
> roelj pushed a commit to branch master
> in repository guix.
>
> commit 5e3010a2ac651397e0cb69239a7d7aa3c0a5703e
> Author: Roel Janssen <roel@gnu.org>
> Date: Wed Apr 18 23:00:41 2018 +0200
>
> gnu: Add guile-curl.
>
> * gnu/packages/curl.scm (guile-curl): New variable.
[...]
> + (modify-phases %standard-phases
> + (add-after 'install 'patch-extension-path
> + (lambda* (#:key outputs #:allow-other-keys)
> + (let* ((out (assoc-ref outputs "out"))
> + (curl.scm (string-append
> + out "/share/guile/site/2.2/curl.scm"))
> + (curl.go (string-append
> + out "/lib/guile/2.2/site-ccache/curl.go"))
> + (ext (string-append out "/lib/guile/2.2/"
> + "extensions/libguile-curl")))
> + (substitute* curl.scm (("libguile-curl") ext))
> + ;; The build system does not actually compile the Scheme module.
> + ;; So we can compile it and put it in the right place in one go.
> + (system* "guild" "compile" curl.scm "-o" curl.go))
> + #t)))))
Please use 'invoke' instead of 'system*' from now on, so that errors in
the subprocess will be detected and reported using exceptions. As you
have it now, compile failures will be ignored.
Would you like to push a fix?
Mark
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: 01/01: gnu: Add guile-curl.
2018-04-19 12:20 ` 01/01: gnu: Add guile-curl Mark H Weaver
@ 2018-04-19 12:31 ` Roel Janssen
0 siblings, 0 replies; 2+ messages in thread
From: Roel Janssen @ 2018-04-19 12:31 UTC (permalink / raw)
To: Mark H Weaver; +Cc: guix-devel
Mark H Weaver <mhw@netris.org> writes:
> Hi Roel,
>
> roel@gnu.org (Roel Janssen) writes:
>
>> roelj pushed a commit to branch master
>> in repository guix.
>>
>> commit 5e3010a2ac651397e0cb69239a7d7aa3c0a5703e
>> Author: Roel Janssen <roel@gnu.org>
>> Date: Wed Apr 18 23:00:41 2018 +0200
>>
>> gnu: Add guile-curl.
>>
>> * gnu/packages/curl.scm (guile-curl): New variable.
>
> [...]
>
>> + (modify-phases %standard-phases
>> + (add-after 'install 'patch-extension-path
>> + (lambda* (#:key outputs #:allow-other-keys)
>> + (let* ((out (assoc-ref outputs "out"))
>> + (curl.scm (string-append
>> + out "/share/guile/site/2.2/curl.scm"))
>> + (curl.go (string-append
>> + out "/lib/guile/2.2/site-ccache/curl.go"))
>> + (ext (string-append out "/lib/guile/2.2/"
>> + "extensions/libguile-curl")))
>> + (substitute* curl.scm (("libguile-curl") ext))
>> + ;; The build system does not actually compile the Scheme module.
>> + ;; So we can compile it and put it in the right place in one go.
>> + (system* "guild" "compile" curl.scm "-o" curl.go))
>> + #t)))))
>
> Please use 'invoke' instead of 'system*' from now on, so that errors in
> the subprocess will be detected and reported using exceptions. As you
> have it now, compile failures will be ignored.
Whoops. I will try to clear my brain's internal cache.
Thanks for letting me know.
>
> Would you like to push a fix?
I pushed a fix in d28e5ad23.
Kind regards,
Roel Janssen
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-04-19 12:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20180418210130.32311.11971@vcs0.savannah.gnu.org>
[not found] ` <20180418210131.A20A7204F1@vcs0.savannah.gnu.org>
2018-04-19 12:20 ` 01/01: gnu: Add guile-curl Mark H Weaver
2018-04-19 12:31 ` Roel Janssen
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).