Re: [PATCH] gnu: Add the-silver-searcher.

[ludo@gnu.org (Ludovic Courtès)]

Tomáš Čech <sleep_walker@gnu.org> skribis:

> * gnu/packages/code.scm (the-silver-searcher): New variable.

[...]

> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append
> +                    "https://github.com/ggreer/the_silver_searcher/archive/"
> +                                  version ".tar.gz"))

Indentation.

> +              (sha256
> +               (base32
> +                "0ah7vcqprl9hhafi68bvzaiywy7dfm28zf7kpw3xrlqzfn0vg7kp"))))

Please add this field to the origin:

  (file-name (string-append name "-" version ".tar.gz"))

so the source tarball in the store has a more meaningful name.

> +       ;; there is no configure yet, so lets create it, but let configure and
> +       ;; make do the work in later phases

“There” and “let’s” plus final period.

> +       (alist-cons-before 'configure 'autoconf
> +                          (lambda _
> +                            (substitute* "build.sh" (("./configure") "true")
> +                                         (("make -j4") "true"))

Please indent the ‘substitute*’ form as is done in the other files.

> +    (description
> +     "The silver searcher - shortly ag - is tool for quickly searching through

“The silver search, or 'ag', is a tool”

OK to push with these changes, thank you!

Ludo’.