From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] gnu: Add the-silver-searcher.
Date: Fri, 20 Mar 2015 21:22:13 +0100
Message-ID: <87vbhv772i.fsf@gnu.org>
References: <1426772720-28337-1-git-send-email-sleep_walker@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52894)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1YZ3Qy-0004zn-7V
	for guix-devel@gnu.org; Fri, 20 Mar 2015 16:22:21 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1YZ3Qv-0001j0-24
	for guix-devel@gnu.org; Fri, 20 Mar 2015 16:22:20 -0400
Received: from fencepost.gnu.org ([2001:4830:134:3::e]:45334)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1YZ3Qu-0001is-VU
	for guix-devel@gnu.org; Fri, 20 Mar 2015 16:22:16 -0400
In-Reply-To: <1426772720-28337-1-git-send-email-sleep_walker@gnu.org>
	(=?utf-8?B?IlRvbcOhxaEJxIxlY2giJ3M=?= message of "Thu,
	19 Mar 2015 14:45:20 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: =?utf-8?B?VG9tw6HFoSDEjGVjaA==?= <sleep_walker@gnu.org>
Cc: guix-devel@gnu.org

Tom=C3=A1=C5=A1 =C4=8Cech <sleep_walker@gnu.org> skribis:

> * gnu/packages/code.scm (the-silver-searcher): New variable.

[...]

> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append
> +                    "https://github.com/ggreer/the_silver_searcher/archi=
ve/"
> +                                  version ".tar.gz"))

Indentation.

> +              (sha256
> +               (base32
> +                "0ah7vcqprl9hhafi68bvzaiywy7dfm28zf7kpw3xrlqzfn0vg7kp"))=
))

Please add this field to the origin:

  (file-name (string-append name "-" version ".tar.gz"))

so the source tarball in the store has a more meaningful name.

> +       ;; there is no configure yet, so lets create it, but let configur=
e and
> +       ;; make do the work in later phases

=E2=80=9CThere=E2=80=9D and =E2=80=9Clet=E2=80=99s=E2=80=9D plus final peri=
od.

> +       (alist-cons-before 'configure 'autoconf
> +                          (lambda _
> +                            (substitute* "build.sh" (("./configure") "tr=
ue")
> +                                         (("make -j4") "true"))

Please indent the =E2=80=98substitute*=E2=80=99 form as is done in the othe=
r files.

> +    (description
> +     "The silver searcher - shortly ag - is tool for quickly searching t=
hrough

=E2=80=9CThe silver search, or 'ag', is a tool=E2=80=9D

OK to push with these changes, thank you!

Ludo=E2=80=99.