From: Alex Kost <alezost@gmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] services: Add console-keymap service.
Date: Thu, 30 Apr 2015 19:22:24 +0300 [thread overview]
Message-ID: <87vbgdmvr3.fsf@gmail.com> (raw)
In-Reply-To: <87bni6fzv9.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Wed, 29 Apr 2015 22:23:06 +0200")
Ludovic Courtès (2015-04-29 23:23 +0300) wrote:
> Alex Kost <alezost@gmail.com> skribis:
>
> [...]
>
>> + (documentation
>> + (string-append "Load '" file "' console keymap (loadkeys)."))
>
> Please make it a literal string, thus omitting FILE entirely.
OK, do you mean like this?:
"Load console keymap (loadkeys)."
> Otherwise LGTM, please push.
Thanks.
> Eventually, this should probably be promoted as a field in
> ‘operating-system’, with the service automatically added as part of
> ‘essential-services’. WDYT?
Probably; I don't have an opinion on that.
--
Alex
next prev parent reply other threads:[~2015-04-30 16:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-25 20:24 [PATCH] services: Add console-keymap service Alex Kost
2015-04-25 23:53 ` 宋文武
2015-04-29 20:23 ` Ludovic Courtès
2015-04-30 16:22 ` Alex Kost [this message]
2015-04-30 16:37 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vbgdmvr3.fsf@gmail.com \
--to=alezost@gmail.com \
--cc=guix-devel@gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).