From mboxrd@z Thu Jan  1 00:00:00 1970
From: Alex Kost <alezost@gmail.com>
Subject: Re: [PATCH] services: Add console-keymap service.
Date: Thu, 30 Apr 2015 19:22:24 +0300
Message-ID: <87vbgdmvr3.fsf@gmail.com>
References: <87vbgkj6qt.fsf@gmail.com> <87bni6fzv9.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45529)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alezost@gmail.com>) id 1YnrET-0001gJ-I5
	for guix-devel@gnu.org; Thu, 30 Apr 2015 12:22:38 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alezost@gmail.com>) id 1YnrEO-0005Km-S6
	for guix-devel@gnu.org; Thu, 30 Apr 2015 12:22:37 -0400
In-Reply-To: <87bni6fzv9.fsf@gnu.org> ("Ludovic
	\=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\=
	\=\?utf-8\?Q\?s\?\= message of "Wed, 29 Apr 2015 22:23:06 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Ludovic =?utf-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Cc: guix-devel@gnu.org

Ludovic Court=C3=A8s (2015-04-29 23:23 +0300) wrote:

> Alex Kost <alezost@gmail.com> skribis:
>
> [...]
>
>> +      (documentation
>> +       (string-append "Load '" file "' console keymap (loadkeys)."))
>
> Please make it a literal string, thus omitting FILE entirely.

OK, do you mean like this?:

  "Load console keymap (loadkeys)."

> Otherwise LGTM, please push.

Thanks.

> Eventually, this should probably be promoted as a field in
> =E2=80=98operating-system=E2=80=99, with the service automatically added =
as part of
> =E2=80=98essential-services=E2=80=99.  WDYT?

Probably; I don't have an opinion on that.

--=20
Alex