[PATCH] Add Rakarrack.

[PATCH] Add Rakarrack.

[Ricardo Wurmus]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: 0001-gnu-Add-Rakarrack.patch --]
[-- Type: text/x-patch, Size: 3065 bytes --]

From 0be8c8413caeee3240f58b05347b450fd52c55e3 Mon Sep 17 00:00:00 2001
From: Ricardo Wurmus <rekado@elephly.net>
Date: Sun, 22 Nov 2015 16:45:18 +0100
Subject: [PATCH] gnu: Add Rakarrack.

* gnu/packages/audio.scm (rakarrack): New variable.
---
 gnu/packages/audio.scm | 52 ++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 52 insertions(+)

diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
index 7d912b8..17b6f52 100644
--- a/gnu/packages/audio.scm
+++ b/gnu/packages/audio.scm
@@ -42,6 +42,8 @@
   #:use-module (gnu packages databases)
   #:use-module (gnu packages file)
   #:use-module (gnu packages flex)
+  #:use-module (gnu packages fltk)
+  #:use-module (gnu packages fontutils)
   #:use-module (gnu packages gettext)
   #:use-module (gnu packages glib)
   #:use-module (gnu packages gtk)
@@ -589,6 +591,56 @@ from a simple noise gate to modulation effects like flanger, phaser or
 auto-wah.")
     (license license:gpl2+)))
 
+(define-public rakarrack
+  (package
+    (name "rakarrack")
+    (version "0.6.1")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "mirror://sourceforge/rakarrack/rakarrack/"
+                                  "rakarrack-" version "/rakarrack-"
+                                  version ".tar.bz2"))
+              (sha256
+               (base32
+                "1rpf63pdn54c4yg13k7cb1w1c7zsvl97c4qxcpz41c8l91xd55kn"))
+              (modules '((guix build utils)))
+              (snippet
+               '(begin
+                  (substitute* '("src/process.C"
+                                 "src/global.h")
+                    (("#include <Fl/") "#include <FL/"))
+                  #t))))
+    (build-system gnu-build-system)
+    (inputs
+     `(("alsa-utils" ,alsa-utils)
+       ("fltk" ,fltk)
+       ("libx11" ,libx11)
+       ("libxext" ,libxext)
+       ("libxfixes" ,libxfixes)
+       ("libxft" ,libxft)
+       ("libxrender" ,libxrender)
+       ("libxpm" ,libxpm)
+       ("fontconfig" ,fontconfig)
+       ("freetype" ,freetype)
+       ("jack" ,jack-1)
+       ("alsa-lib" ,alsa-lib)
+       ("libsndfile" ,libsndfile)
+       ("libsamplerate" ,libsamplerate)
+       ("zlib" ,zlib)))
+    (home-page "http://rakarrack.sourceforge.net/")
+    (synopsis "Audio effects processor")
+    (description
+     "Rakarrack is a richly featured multi-effects processor emulating a
+guitar effects pedalboard.  Effects include compressor, expander, noise gate,
+equalizers, exciter, flangers, chorus, various delay and reverb effects,
+distortion modules and many more.  Most of the effects engine is built from
+modules found in the excellent software synthesizer ZynAddSubFX.  Presets and
+user interface are optimized for guitar, but Rakarrack processes signals in
+stereo while it does not apply internal band-limiting filtering, and thus is
+well suited to all musical instruments and vocals.")
+    ;; There is no "or later" clause to be found.
+    (license license:gpl2)))
+
 (define-public ir
   (package
     (name "ir")
-- 
2.5.0

Re: [PATCH] Add Rakarrack.

[Ludovic Courtès]

Ricardo Wurmus <rekado@elephly.net> skribis:

> From 0be8c8413caeee3240f58b05347b450fd52c55e3 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <rekado@elephly.net>
> Date: Sun, 22 Nov 2015 16:45:18 +0100
> Subject: [PATCH] gnu: Add Rakarrack.
>
> * gnu/packages/audio.scm (rakarrack): New variable.

[...]

> +    ;; There is no "or later" clause to be found.
> +    (license license:gpl2)))

But if there are no headers explicitly say “GNU GPL version 2”, then
it’s effectively at the user’s choice, so gpl2+.

Otherwise LGTM, thank you!

Ludo’.

Re: [PATCH] Add Rakarrack.

[Ricardo Wurmus]

Ludovic Courtès <ludo@gnu.org> writes:

> Ricardo Wurmus <rekado@elephly.net> skribis:
>
>> From 0be8c8413caeee3240f58b05347b450fd52c55e3 Mon Sep 17 00:00:00 2001
>> From: Ricardo Wurmus <rekado@elephly.net>
>> Date: Sun, 22 Nov 2015 16:45:18 +0100
>> Subject: [PATCH] gnu: Add Rakarrack.
>>
>> * gnu/packages/audio.scm (rakarrack): New variable.
>
> [...]
>
>> +    ;; There is no "or later" clause to be found.
>> +    (license license:gpl2)))
>
> But if there are no headers explicitly say “GNU GPL version 2”, then
> it’s effectively at the user’s choice, so gpl2+.

Unfortunately, the headers explicitly state that only version 2 is
valid.

  This program is free software; you can redistribute it and/or modify
  it under the terms of version 2 of the GNU General Public License
  as published by the Free Software Foundation.
 
  This program is distributed in the hope that it will be useful,
  but WITHOUT ANY WARRANTY; without even the implied warranty of
  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  GNU General Public License (version 2) for more details.
 
  You should have received a copy of the GNU General Public License
  (version2)  along with this program; if not, write to the Free Software
  Foundation,
  Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307 USA

I’ll update the comment to make this clear and then push.
Thanks for the review!

~~ Ricardo