unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: guix-devel@gnu.org
Subject: Re: branch master updated: gnu: gnuradio: Fix runtime python environment for plugins.
Date: Fri, 01 May 2020 23:29:43 +0200	[thread overview]
Message-ID: <87v9lfcpiw.fsf@gnu.org> (raw)
In-Reply-To: <20200430082115.25315.99707@vcs0.savannah.gnu.org> (guix-commits@gnu.org's message of "Thu, 30 Apr 2020 04:21:15 -0400")

Hi Guillaume,

guix-commits@gnu.org skribis:

>      (native-search-paths
> +     ;; Variables required to find third-party plugins at runtime.
>       (list (search-path-specification
>              (variable "GRC_BLOCKS_PATH")
> -            (files '("/share/gnuradio/grc/blocks")))))
> +            (files '("share/gnuradio/grc/blocks")))
> +           (search-path-specification
> +            (variable "PYTHONPATH")
> +            (files (list (string-append "lib/python"
> +                                        (version-major+minor
> +                                         (package-version python))
> +                                        "/site-packages"))))))
>      (synopsis "Toolkit for software-defined radios")

It’s not OK to have PYTHONPATH in here because that variable “belongs”
to Python, not to GNU Radio.

A profile containing both gnuradio and python will have PYTHONPATH
correctly set.  However, I guess you want to ensure that PYTHONPATH is
correct even when Python is not in the profile, right?

In that case, I’d recommend wrapping the gnuradio executables such that
PYTHONPATH is correct.

Does that make sense?

See also one of our oldest bugs: <https://issues.guix.gnu.org/issue/22138>.

(Apologies if I missed a previous discussion!)

Thanks,
Ludo’.


       reply	other threads:[~2020-05-01 21:29 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20200430082115.25315.99707@vcs0.savannah.gnu.org>
2020-05-01 21:29 ` Ludovic Courtès [this message]
2020-05-02  8:40   ` branch master updated: gnu: gnuradio: Fix runtime python environment for plugins Guillaume Le Vaillant

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v9lfcpiw.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).