From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <guix-devel-bounces+larch=yhetil.org@gnu.org>
Received: from mp0 ([2001:41d0:2:4a6f::])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	by ms11 with LMTPS
	id +GGHI8yUrF6OJAAA0tVLHw
	(envelope-from <guix-devel-bounces+larch=yhetil.org@gnu.org>)
	for <larch@yhetil.org>; Fri, 01 May 2020 21:29:48 +0000
Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	by mp0 with LMTPS
	id 4NiUL9WUrF4TCQAA1q6Kng
	(envelope-from <guix-devel-bounces+larch=yhetil.org@gnu.org>)
	for <larch@yhetil.org>; Fri, 01 May 2020 21:29:57 +0000
Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:470:142::17])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by aspmx1.migadu.com (Postfix) with ESMTPS id CE3CF941BD0
	for <larch@yhetil.org>; Fri,  1 May 2020 21:29:56 +0000 (UTC)
Received: from localhost ([::1]:43922 helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <guix-devel-bounces+larch=yhetil.org@gnu.org>)
	id 1jUdEK-0000H3-Vu
	for larch@yhetil.org; Fri, 01 May 2020 17:29:57 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:46184)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <ludo@gnu.org>) id 1jUdEB-0000Gp-4W
 for guix-devel@gnu.org; Fri, 01 May 2020 17:29:48 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:38242)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <ludo@gnu.org>)
 id 1jUdE9-0006yv-NS; Fri, 01 May 2020 17:29:45 -0400
Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=42846 helo=ribbon)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <ludo@gnu.org>)
 id 1jUdE8-0007dL-Px; Fri, 01 May 2020 17:29:45 -0400
From: =?utf-8?Q?Ludovic_Court=C3=A8s?= <ludo@gnu.org>
To: guix-devel@gnu.org
Subject: Re: branch master updated: gnu: gnuradio: Fix runtime python
 environment for plugins.
References: <20200430082115.25315.99707@vcs0.savannah.gnu.org>
X-URL: http://www.fdn.fr/~lcourtes/
X-Revolutionary-Date: 13 =?utf-8?Q?Flor=C3=A9al?= an 228 de la =?utf-8?Q?R?=
 =?utf-8?Q?=C3=A9volution?=
X-PGP-Key-ID: 0x090B11993D9AEBB5
X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc
X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4  0CFB 090B 1199 3D9A EBB5
X-OS: x86_64-pc-linux-gnu
Date: Fri, 01 May 2020 23:29:43 +0200
In-Reply-To: <20200430082115.25315.99707@vcs0.savannah.gnu.org>
 (guix-commits@gnu.org's message of "Thu, 30 Apr 2020 04:21:15 -0400")
Message-ID: <87v9lfcpiw.fsf@gnu.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-BeenThere: guix-devel@gnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "Development of GNU Guix and the GNU System distribution."
 <guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
 <mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
 <mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+larch=yhetil.org@gnu.org>
X-Scanner: scn0
X-Spam-Score: -1.01
Authentication-Results: aspmx1.migadu.com;
	dkim=none;
	dmarc=none;
	spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 2001:470:142::17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org
X-Scan-Result: default: False [-1.01 / 13.00];
	 RCVD_VIA_SMTP_AUTH(0.00)[];
	 GENERIC_REPUTATION(0.00)[-0.49545666371467];
	 DWL_DNSWL_FAIL(0.00)[2001:470:142::17:server fail];
	 R_SPF_ALLOW(-0.20)[+ip6:2001:470:142::/48:c];
	 IP_REPUTATION_HAM(0.00)[asn: 22989(0.16), country: US(-0.00), ip: 2001:470:142::17(-0.50)];
	 TO_DN_NONE(0.00)[];
	 MX_GOOD(-0.50)[cached: eggs.gnu.org];
	 MAILLIST(-0.20)[mailman];
	 FORGED_RECIPIENTS_MAILLIST(0.00)[];
	 RCVD_TLS_LAST(0.00)[];
	 R_DKIM_NA(0.00)[];
	 MID_RHS_MATCH_FROM(0.00)[];
	 TAGGED_FROM(0.00)[larch=yhetil.org];
	 ASN(0.00)[asn:22989, ipnet:2001:470:142::/48, country:US];
	 ARC_NA(0.00)[];
	 RCVD_COUNT_FIVE(0.00)[5];
	 FROM_NEQ_ENVFROM(0.00)[ludo@gnu.org,guix-devel-bounces@gnu.org];
	 FROM_HAS_DN(0.00)[];
	 TO_DOM_EQ_FROM_DOM(0.00)[];
	 URIBL_BLOCKED(0.00)[gnu.org:email];
	 MIME_GOOD(-0.10)[text/plain];
	 MIME_TRACE(0.00)[0:+];
	 DMARC_NA(0.00)[gnu.org];
	 HAS_LIST_UNSUB(-0.01)[];
	 RCPT_COUNT_ONE(0.00)[1];
	 DNSWL_BLOCKED(0.00)[2001:470:142::17:from];
	 FORGED_SENDER_MAILLIST(0.00)[]
X-TUID: buseRyItnKDG

Hi Guillaume,

guix-commits@gnu.org skribis:

>      (native-search-paths
> +     ;; Variables required to find third-party plugins at runtime.
>       (list (search-path-specification
>              (variable "GRC_BLOCKS_PATH")
> -            (files '("/share/gnuradio/grc/blocks")))))
> +            (files '("share/gnuradio/grc/blocks")))
> +           (search-path-specification
> +            (variable "PYTHONPATH")
> +            (files (list (string-append "lib/python"
> +                                        (version-major+minor
> +                                         (package-version python))
> +                                        "/site-packages"))))))
>      (synopsis "Toolkit for software-defined radios")

It=E2=80=99s not OK to have PYTHONPATH in here because that variable =E2=80=
=9Cbelongs=E2=80=9D
to Python, not to GNU Radio.

A profile containing both gnuradio and python will have PYTHONPATH
correctly set.  However, I guess you want to ensure that PYTHONPATH is
correct even when Python is not in the profile, right?

In that case, I=E2=80=99d recommend wrapping the gnuradio executables such =
that
PYTHONPATH is correct.

Does that make sense?

See also one of our oldest bugs: <https://issues.guix.gnu.org/issue/22138>.

(Apologies if I missed a previous discussion!)

Thanks,
Ludo=E2=80=99.