Re: GNU Guix 1.2.0rc1 available for testing!

[Mathieu Othacehe <othacehe@gnu.org>]

[-- Attachment #1: Type: text/plain, Size: 825 bytes --]


Hello Florian,

> Nov 15 23:53:03 localhost installer[259]: crashing due to uncaught exception: misc-error (#f "~A" ("Device /dev/sda is still in use.") #f) 
> Nov 15 23:53:03 localhost installer[259]: running form #<newt-form 865370> ("Unexpected problem") with 0 clients 

Many thanks (again) for your help here! According to the backtrace you
sent earlier in this thread, it looks like the crash occurs in the
"free-parted" procedure.

This procedure tries to unallocate Parted resources and waits for the
partition table changes to be synchronized to disk. The
"with-delay-device-in-use?" tries 4 times every 250ms to detect if the
device is still in use.

Maybe it takes longer on your HW to synchronize the partition tables. If
you could test the attached patch on top of 1.2.0 it would be terrific.

Thanks,

Mathieu

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Increase-device-use-delay.patch --]
[-- Type: text/x-diff, Size: 908 bytes --]

From 6fec27303d0f8767ed48c507af67908a0fcf17a0 Mon Sep 17 00:00:00 2001
From: Mathieu Othacehe <othacehe@gnu.org>
Date: Mon, 16 Nov 2020 10:10:56 +0100
Subject: [PATCH] Increase device use delay.

---
 gnu/installer/parted.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/installer/parted.scm b/gnu/installer/parted.scm
index f2352c5779..ed3af6af85 100644
--- a/gnu/installer/parted.scm
+++ b/gnu/installer/parted.scm
@@ -318,7 +318,7 @@ PARTED-OBJECT field equals PARTITION, return #f if not found."
 fail. See rereadpt function in wipefs.c of util-linux for an explanation."
   ;; Kernel always return EINVAL for BLKRRPART on loopdevices.
   (and (not (string-match "/dev/loop*" file-name))
-       (let loop ((try 4))
+       (let loop ((try 16))
          (usleep 250000)
          (let ((in-use? (device-in-use? file-name)))
            (if (and in-use? (> try 0))
-- 
2.29.2