From: "Ludovic Courtès" <ludo@gnu.org>
To: Mathieu Othacehe <othacehe@gnu.org>
Cc: guix-devel@gnu.org
Subject: Re: GNU Guix 1.2.0rc1 available for testing!
Date: Tue, 17 Nov 2020 10:30:24 +0100 [thread overview]
Message-ID: <871rgstjnz.fsf@gnu.org> (raw)
In-Reply-To: <87v9e5ll7a.fsf@gnu.org> (Mathieu Othacehe's message of "Mon, 16 Nov 2020 10:12:09 +0100")
Hi Mathieu,
Mathieu Othacehe <othacehe@gnu.org> skribis:
> From 6fec27303d0f8767ed48c507af67908a0fcf17a0 Mon Sep 17 00:00:00 2001
> From: Mathieu Othacehe <othacehe@gnu.org>
> Date: Mon, 16 Nov 2020 10:10:56 +0100
> Subject: [PATCH] Increase device use delay.
>
> ---
> gnu/installer/parted.scm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gnu/installer/parted.scm b/gnu/installer/parted.scm
> index f2352c5779..ed3af6af85 100644
> --- a/gnu/installer/parted.scm
> +++ b/gnu/installer/parted.scm
> @@ -318,7 +318,7 @@ PARTED-OBJECT field equals PARTITION, return #f if not found."
> fail. See rereadpt function in wipefs.c of util-linux for an explanation."
> ;; Kernel always return EINVAL for BLKRRPART on loopdevices.
> (and (not (string-match "/dev/loop*" file-name))
> - (let loop ((try 4))
> + (let loop ((try 16))
> (usleep 250000)
> (let ((in-use? (device-in-use? file-name)))
> (if (and in-use? (> try 0))
Should we go ahead and apply this one? Not polling would be nicer, but
maybe there’s no real way to do that?
BTW:
(string-match "/dev/loop*" file-name)
should almost certainly be:
(string-prefix? "/dev/loop" file-name)
The regexp above would match “/dev/loo”, “qux/dev/looppppppppabc”, etc.
WDYT?
Thanks,
Ludo’.
next prev parent reply other threads:[~2020-11-17 9:30 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-13 17:07 GNU Guix 1.2.0rc1 available for testing! Ludovic Courtès
2020-11-15 16:19 ` zimoun
2020-11-15 19:16 ` pelzflorian (Florian Pelz)
2020-11-15 21:53 ` Marius Bakke
2020-11-15 23:16 ` pelzflorian (Florian Pelz)
2020-11-16 9:12 ` Mathieu Othacehe
2020-11-16 11:47 ` pelzflorian (Florian Pelz)
2020-11-17 9:02 ` Mathieu Othacehe
2020-11-17 12:13 ` pelzflorian (Florian Pelz)
2020-11-16 15:49 ` Miguel Ángel Arruga Vivas
2020-11-17 9:06 ` Mathieu Othacehe
2020-11-17 9:30 ` Ludovic Courtès [this message]
2020-11-17 9:38 ` Mathieu Othacehe
2020-11-17 14:41 ` Ludovic Courtès
2020-11-17 15:26 ` zimoun
2020-11-17 21:19 ` Ludovic Courtès
2020-11-17 15:41 ` pelzflorian (Florian Pelz)
2020-11-17 18:13 ` Mathieu Othacehe
2020-11-25 18:26 ` Tobias Platen
2020-11-27 10:10 ` Ludovic Courtès
2020-11-27 11:09 ` Ricardo Wurmus
2020-11-17 23:12 ` Mark H Weaver
2020-11-16 15:39 ` Miguel Ángel Arruga Vivas
2020-11-16 0:10 ` Oleg Pykhalov
2020-11-16 9:06 ` Ludovic Courtès
2020-11-16 16:24 ` John Soo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871rgstjnz.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
--cc=othacehe@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).