unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Munyoki Kilyungi <me@bonfacemunyoki.com>
To: jgart <jgart@dismail.de>, guix-devel@gnu.org
Subject: Re: IDEA: missing-tests-pypi-error? condition
Date: Fri, 06 Oct 2023 12:09:28 +0300	[thread overview]
Message-ID: <87v8bkxgl3.fsf@saitama.mail-host-address-is-not-set> (raw)
In-Reply-To: <41cf39960ed499205b21e677c872a29f@dismail.de>

[-- Attachment #1: Type: text/plain, Size: 991 bytes --]

"jgart" <jgart@dismail.de> aliandika:

> Hi Guixers,
>
> I was recently reviewing a patch by a contributor and was discussing the notion of preferring upstream to PyPI when tests are missing on PyPI.
>
What's the policy on this.  Shouldn't we prefer
upstream over PyPI?  Sometimes, PyPI versions lag
behind upstream versions.

> WDYT if we also signalled a special condition when there are missing tests in PyPI?
>
I posit that this should be the responsibility of
the contributor.  Adding extra glue can add
unnecessary complexity.

> I'm thinking of something similar to here:
>
> https://git.savannah.gnu.org/cgit/guix.git/tree/guix/import/pypi.scm?h=master#n562
>
> Maybe it can be a missing-tests-pypi-error?
>
> This email is gluten-free, vegan, and 100% organic,
>
> jgart
>

-- 
(Life is like a pencil that will surely run out,
    but will leave the beautiful writing of life.)
(D4F09EB110177E03C28E2FE1F5BBAE1E0392253F
    (hkp://keys.openpgp.org))

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 865 bytes --]

  reply	other threads:[~2023-10-06  9:11 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-04 13:08 IDEA: missing-tests-pypi-error? condition jgart
2023-10-06  9:09 ` Munyoki Kilyungi [this message]
2023-10-06 13:03   ` Maxim Cournoyer
2023-10-06 15:00     ` Munyoki Kilyungi
2023-10-07 16:07       ` Maxim Cournoyer
2023-10-08 13:11       ` jgart
2023-10-08 16:17         ` Luis Felipe
2023-10-09  0:52         ` Maxim Cournoyer
2023-10-09 13:36         ` Josselin Poiret
2023-10-09 13:57         ` jgart
2023-10-09 17:17           ` Maxim Cournoyer
2023-10-12  5:49             ` Efraim Flashner
2023-10-06 11:10 ` jgart
2023-10-06 12:50   ` Munyoki Kilyungi
2023-10-07 16:05     ` Maxim Cournoyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v8bkxgl3.fsf@saitama.mail-host-address-is-not-set \
    --to=me@bonfacemunyoki.com \
    --cc=guix-devel@gnu.org \
    --cc=jgart@dismail.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).