Testing changes on Berlin before pushing changes? (Was: Re: bug#35521: Mariadb test suite failures on x86_64-linux)

Testing changes on Berlin before pushing changes? (Was: Re: bug#35521: Mariadb test suite failures on x86_64-linux)

[Chris Marusich]

[-- Attachment #1: Type: text/plain, Size: 2187 bytes --]

Hi Marius,

Thank you for your work on Mariadb in bug 35521.  You are a hero!  Well,
my hero at least, since this was blocking me from upgrading things.  :-)

Marius Bakke <mbakke@fastmail.com> writes:

> I was about to push this patch to core-updates:
>
> diff --git a/gnu/packages/databases.scm b/gnu/packages/databases.scm
> index 6bfeaad9a2..5d256b1af2 100644
> --- a/gnu/packages/databases.scm
> +++ b/gnu/packages/databases.scm
> @@ -706,9 +706,6 @@ Language.")
>                        ;; 2030-12-31.  See <https://bugs.gnu.org/34351> for details.
>                        "main.mysqldump"
>  
> -                      ;; XXX: Fails sporadically.
> -                      "innodb_fts.crash_recovery"
> -
>                        ;; FIXME: This test fails on i686:
>                        ;; -myisampack: Can't create/write to file (Errcode: 17 "File exists")
>                        ;; +myisampack: Can't create/write to file (Errcode: 17 "File exists)
> @@ -753,7 +750,10 @@ Language.")
>                   (with-directory-excursion "mysql-test"
>                     (invoke "./mtr" "--verbose"
>                             "--retry=3"
> -                           "--testcase-timeout=40"
> +                           ;; On x86_64 we need a long timeout because of the
> +                           ;; TokuDB engine, whose individual test cases often
> +                           ;; require more than 1 hour to complete on busy hosts.
> +                           "--testcase-timeout=90"
>                             "--suite-timeout=600"
>                             "--parallel" (number->string (parallel-job-count))
>                             "--skip-test-list=unstable-tests"))
>
>
> Lo and behold, tokudb_bugs.mdev4533 failed when I tried it on Berlin.

Perhaps I'm misunderstanding what you said, but it sounds like you were
able to test a change on Berlin without committing it to the
core-updates branch in Savannah.  Is that right?  If so, how did you do
it?  Being able to quickly test changes on better hardware than my puny
X200 could prove useful, and I'm sure others would find it useful, too.

-- 
Chris

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

Re: Testing changes on Berlin before pushing changes? (Was: Re: bug#35521: Mariadb test suite failures on x86_64-linux)

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 2700 bytes --]

Chris Marusich <cmmarusich@gmail.com> writes:

> Hi Marius,
>
> Thank you for your work on Mariadb in bug 35521.  You are a hero!  Well,
> my hero at least, since this was blocking me from upgrading things.  :-)

Glad it worked for you :-)

>
> Marius Bakke <mbakke@fastmail.com> writes:
>
>> I was about to push this patch to core-updates:
>>
>> diff --git a/gnu/packages/databases.scm b/gnu/packages/databases.scm
>> index 6bfeaad9a2..5d256b1af2 100644
>> --- a/gnu/packages/databases.scm
>> +++ b/gnu/packages/databases.scm
>> @@ -706,9 +706,6 @@ Language.")
>>                        ;; 2030-12-31.  See <https://bugs.gnu.org/34351> for details.
>>                        "main.mysqldump"
>>  
>> -                      ;; XXX: Fails sporadically.
>> -                      "innodb_fts.crash_recovery"
>> -
>>                        ;; FIXME: This test fails on i686:
>>                        ;; -myisampack: Can't create/write to file (Errcode: 17 "File exists")
>>                        ;; +myisampack: Can't create/write to file (Errcode: 17 "File exists)
>> @@ -753,7 +750,10 @@ Language.")
>>                   (with-directory-excursion "mysql-test"
>>                     (invoke "./mtr" "--verbose"
>>                             "--retry=3"
>> -                           "--testcase-timeout=40"
>> +                           ;; On x86_64 we need a long timeout because of the
>> +                           ;; TokuDB engine, whose individual test cases often
>> +                           ;; require more than 1 hour to complete on busy hosts.
>> +                           "--testcase-timeout=90"
>>                             "--suite-timeout=600"
>>                             "--parallel" (number->string (parallel-job-count))
>>                             "--skip-test-list=unstable-tests"))
>>
>>
>> Lo and behold, tokudb_bugs.mdev4533 failed when I tried it on Berlin.
>
> Perhaps I'm misunderstanding what you said, but it sounds like you were
> able to test a change on Berlin without committing it to the
> core-updates branch in Savannah.  Is that right?  If so, how did you do
> it?  Being able to quickly test changes on better hardware than my puny
> X200 could prove useful, and I'm sure others would find it useful, too.

I recently added myself as a sysadmin on Berlin at Ludovics request:

https://git.savannah.gnu.org/cgit/guix/maintenance.git/commit/?id=aefeccaae06027e0d03563b24fd1f9ac6855edaf

Contact guix-sysadmin@ if you would like to join.  Note that being
sysadmin on Berlin comes with a certain amount of responsibility in
terms of troubleshooting build failures and watching the CI system ;-)

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

Re: Testing changes on Berlin before pushing changes?

[Chris Marusich]

[-- Attachment #1: Type: text/plain, Size: 621 bytes --]

Hi Marius,

Marius Bakke <mbakke@fastmail.com> writes:

> Chris Marusich <cmmarusich@gmail.com> writes:
>
>> Hi Marius,
>>
>> Thank you for your work on Mariadb in bug 35521.  You are a hero!  Well,
>> my hero at least, since this was blocking me from upgrading things.  :-)
>
> Glad it worked for you :-)

Well, it did seem to work, but it has unmasked two other problems that
still prevent me from upgrading using core-updates:

https://debbugs.gnu.org/cgi/bugreport.cgi?bug=36685
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=36686

I'll try to look into them also, when I have time.

-- 
Chris

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]