unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / Atom feed
* Common Lisp package: all test cases pass but 'check' phase fails
@ 2021-11-18 12:13 Foo Chuan Wei
  2021-11-19 15:17 ` Katherine Cox-Buday
  0 siblings, 1 reply; 3+ messages in thread
From: Foo Chuan Wei @ 2021-11-18 12:13 UTC (permalink / raw)
  To: guix-devel

I have submitted patches to add Common Lisp packages "cl-assoc-utils" [1]
and "cl-let-over-lambda" [2]. If tests are enabled in the package
definition of these two packages, all test cases pass, but an error
occurs at the end of the 'check' phase. For example, the error message
for "cl-let-over-lambda" is:

    Summary:
    All 1 file passed.
    Unhandled ASDF/FIND-COMPONENT:MISSING-DEPENDENCY in thread
    #<SB-THREAD:THREAD "main thread" RUNNING {1001860103}>:
      Component LET-OVER-LAMBDA-ASD::LET-OVER-LAMBDA-TEST not found,
      required by #<SYSTEM "let-over-lambda">

In lisp-xyz.scm, I see that the "cl-locale" package has the same problem
with its tests.

Does anyone here know the cause of the error above?


[1]: https://lists.gnu.org/archive/html/guix-patches/2021-11/msg00786.html
[2]: https://lists.gnu.org/archive/html/guix-patches/2021-11/msg00787.html


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Common Lisp package: all test cases pass but 'check' phase fails
  2021-11-18 12:13 Common Lisp package: all test cases pass but 'check' phase fails Foo Chuan Wei
@ 2021-11-19 15:17 ` Katherine Cox-Buday
  2021-11-20 14:14   ` Guillaume Le Vaillant
  0 siblings, 1 reply; 3+ messages in thread
From: Katherine Cox-Buday @ 2021-11-19 15:17 UTC (permalink / raw)
  To: guix-devel

Foo Chuan Wei <chuanwei.foo@hotmail.com> writes:

> In lisp-xyz.scm, I see that the "cl-locale" package has the same problem
> with its tests.
>
> Does anyone here know the cause of the error above?

Without having time to look at the code, but with the hope that this points you in the right direction:

It probably has something to do with the separate test .asd file. The asdf-build-system is probably copying that file to a place asdf can't find it from the production .asd file. You can probably briefly scan the code and get an idea of what's going on:

https://git.savannah.gnu.org/cgit/guix.git/tree/guix/build/asdf-build-system.scm?h=master#n1

I will do my best to find some time to answer definitively, but I am particularly busy at the moment. Hopefully someone else can chime in with a more specific answer.

-- 
Katherine


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Common Lisp package: all test cases pass but 'check' phase fails
  2021-11-19 15:17 ` Katherine Cox-Buday
@ 2021-11-20 14:14   ` Guillaume Le Vaillant
  0 siblings, 0 replies; 3+ messages in thread
From: Guillaume Le Vaillant @ 2021-11-20 14:14 UTC (permalink / raw)
  To: Foo Chuan Wei; +Cc: guix-devel, Katherine Cox-Buday

[-- Attachment #1: Type: text/plain, Size: 1158 bytes --]

Katherine Cox-Buday <cox.katherine.e@gmail.com> skribis:

> Foo Chuan Wei <chuanwei.foo@hotmail.com> writes:
>
>> In lisp-xyz.scm, I see that the "cl-locale" package has the same problem
>> with its tests.
>>
>> Does anyone here know the cause of the error above?
>
> Without having time to look at the code, but with the hope that this points you in the right direction:
>
> It probably has something to do with the separate test .asd file. The
> asdf-build-system is probably copying that file to a place asdf can't find it
> from the production .asd file. You can probably briefly scan the code and get
> an idea of what's going on:
>
> https://git.savannah.gnu.org/cgit/guix.git/tree/guix/build/asdf-build-system.scm?h=master#n1
>
> I will do my best to find some time to answer definitively, but I am particularly busy at the moment. Hopefully someone else can chime in with a more specific answer.

It looks like these packages are all using the "prove" system for
testing and have a ":defsystem-depends-on (:prove-asdf)" in the system
definition. Maybe prove-asdf is modifying the behavior of asdf in some
way that our asdf-build-system doesn't like.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-11-20 14:24 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-18 12:13 Common Lisp package: all test cases pass but 'check' phase fails Foo Chuan Wei
2021-11-19 15:17 ` Katherine Cox-Buday
2021-11-20 14:14   ` Guillaume Le Vaillant

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).