unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Re: 01/09: services: base: Add extra-env support to guix-configuration.
       [not found] ` <20230107191212.33A63C0061B@vcs2.savannah.gnu.org>
@ 2023-01-09  9:16   ` Ludovic Courtès
  2023-01-09 16:27     ` Mathieu Othacehe
  0 siblings, 1 reply; 2+ messages in thread
From: Ludovic Courtès @ 2023-01-09  9:16 UTC (permalink / raw)
  To: Mathieu Othacehe; +Cc: guix-devel

Hi,

guix-commits@gnu.org skribis:

> commit 78a9b4f996ba18b4460ba380b87e9538007c27e0
> Author: Mathieu Othacehe <othacehe@gnu.org>
> AuthorDate: Sat Jan 7 19:12:30 2023 +0100
>
>     services: base: Add extra-env support to guix-configuration.
>     
>     * gnu/services/base.scm (<guix-configuration>)[extra-env]: New field.
>     (guix-shepherd-service): Honor it.
>     * doc/guix.texi (Base Services): Document it.

[...]

> +@item @code{extra-env} (default: @code{'()})
> +Environment variables to be set before starting the daemon, as a list of
> +@code{key=value} strings.

Nitpick: To stick to existing naming conventions, could we rename it to
‘environment-variables’ or ‘environment’?

Ludo’.


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: 01/09: services: base: Add extra-env support to guix-configuration.
  2023-01-09  9:16   ` 01/09: services: base: Add extra-env support to guix-configuration Ludovic Courtès
@ 2023-01-09 16:27     ` Mathieu Othacehe
  0 siblings, 0 replies; 2+ messages in thread
From: Mathieu Othacehe @ 2023-01-09 16:27 UTC (permalink / raw)
  To: Ludovic Courtès; +Cc: guix-devel


Hey,

> Nitpick: To stick to existing naming conventions, could we rename it to
> ‘environment-variables’ or ‘environment’?

I changed to environment and pushed.

Thanks,

Mathieu


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-01-09 16:27 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <167311873155.26304.2498575057833980868@vcs2.savannah.gnu.org>
     [not found] ` <20230107191212.33A63C0061B@vcs2.savannah.gnu.org>
2023-01-09  9:16   ` 01/09: services: base: Add extra-env support to guix-configuration Ludovic Courtès
2023-01-09 16:27     ` Mathieu Othacehe

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).