unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
* [PATCH] gnu: Add chromaprint.
@ 2016-09-26 18:19 Hartmut Goebel
  2016-10-19 20:25 ` Ludovic Courtès
  0 siblings, 1 reply; 4+ messages in thread
From: Hartmut Goebel @ 2016-09-26 18:19 UTC (permalink / raw)
  To: guix-devel

* gnu/packages/mp3.scm (chromaprint): New variable.
---
 gnu/packages/mp3.scm | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)

diff --git a/gnu/packages/mp3.scm b/gnu/packages/mp3.scm
index 37407cd..3cb653a 100644
--- a/gnu/packages/mp3.scm
+++ b/gnu/packages/mp3.scm
@@ -25,6 +25,7 @@
   #:use-module (gnu packages autotools)
   #:use-module (gnu packages base)
   #:use-module (gnu packages gcc)
+  #:use-module (gnu packages boost)
   #:use-module (gnu packages cdrom)
   #:use-module (gnu packages compression)
   #:use-module (gnu packages gettext)
@@ -38,6 +39,7 @@
   #:use-module (gnu packages xiph)
   #:use-module (gnu packages pulseaudio)
   #:use-module (gnu packages linux)               ;alsa-lib
+  #:use-module (gnu packages video)               ;ffmpeg
   #:use-module (guix packages)
   #:use-module (guix download)
   #:use-module (guix build-system gnu)
@@ -482,3 +484,31 @@ to write your own applications or plugins that are callable from the
 command-line tool.")
     (home-page "http://eyed3.nicfit.net/")
     (license license:gpl2+)))
+
+(define-public chromaprint
+  (package
+    (name "chromaprint")
+    (version "1.3.2")
+    (source (origin
+      (method url-fetch)
+      (uri (string-append
+            "https://bitbucket.org/acoustid/chromaprint/downloads/"
+            "chromaprint-" version ".tar.gz"))
+      (sha256
+       (base32 "0lln8dh33gslb9cbmd1hcv33pr6jxdwipd8m8gbsyhksiq6r1by3"))))
+    (build-system cmake-build-system)
+    (arguments
+     `(#:tests? #f ; tests require googletest *sources*
+       ;;#:configure-flags '("-DBUILD_TESTS=ON") ; for building the tests
+       #:test-target "check"))
+    (inputs
+     ;; requires one of FFmpeg (prefered), FFTW3 or vDSP
+     ;; use the same ffmpeg version as for acoustid-fingerprinter
+     `(("ffmpeg" ,ffmpeg)
+       ("boots" ,boost)))
+    (home-page "http://wiki.acoustid.org/wiki/Chromaprint")
+    (synopsis "Audio fingerprinting library")
+    (description "Chromaprint is a library for calculating audio
+fingerprints which are used by the Acoustid service.  Its main purpose
+is to provide an accurate identifier for record tracks")
+    (license license:lgpl2.1+)))
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] gnu: Add chromaprint.
  2016-09-26 18:19 [PATCH] gnu: Add chromaprint Hartmut Goebel
@ 2016-10-19 20:25 ` Ludovic Courtès
  2016-10-20  7:08   ` Hartmut Goebel
  0 siblings, 1 reply; 4+ messages in thread
From: Ludovic Courtès @ 2016-10-19 20:25 UTC (permalink / raw)
  To: Hartmut Goebel; +Cc: guix-devel

Hi!

Hartmut Goebel <h.goebel@crazy-compilers.com> skribis:

> * gnu/packages/mp3.scm (chromaprint): New variable.

[...]

> +(define-public chromaprint
> +  (package
> +    (name "chromaprint")
> +    (version "1.3.2")
> +    (source (origin
> +      (method url-fetch)
> +      (uri (string-append
> +            "https://bitbucket.org/acoustid/chromaprint/downloads/"
> +            "chromaprint-" version ".tar.gz"))
> +      (sha256
> +       (base32 "0lln8dh33gslb9cbmd1hcv33pr6jxdwipd8m8gbsyhksiq6r1by3"))))
> +    (build-system cmake-build-system)
> +    (arguments
> +     `(#:tests? #f ; tests require googletest *sources*

Weird.

> +    (synopsis "Audio fingerprinting library")
> +    (description "Chromaprint is a library for calculating audio
> +fingerprints which are used by the Acoustid service.  Its main purpose
> +is to provide an accurate identifier for record tracks")
                                                         ^
Missing period.

OK with this change, thank you!

Ludo’.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] gnu: Add chromaprint.
  2016-10-19 20:25 ` Ludovic Courtès
@ 2016-10-20  7:08   ` Hartmut Goebel
  2016-10-20 12:57     ` Ludovic Courtès
  0 siblings, 1 reply; 4+ messages in thread
From: Hartmut Goebel @ 2016-10-20  7:08 UTC (permalink / raw)
  To: Ludovic Courtès; +Cc: guix-devel

Am 19.10.2016 um 22:25 schrieb Ludovic Courtès:
>> > +    (arguments
>> > +     `(#:tests? #f ; tests require googletest *sources*
> Weird.
>

Yes. From the issue I opened on this:[1]

    That's the recommended way to use gtest. It's a C++ library and the
    ABI depends on many compiler options. Debian based distributions
    don't even ship a compiled package of gtest anymore.


IMHO gtest should get onto the list of "software to note use".

[1]https://bitbucket.org/acoustid/chromaprint/issues/19/build-failure-googletest-sources-are

-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | h.goebel@crazy-compilers.com               |
| www.crazy-compilers.com | compilers which you thought are impossible |

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] gnu: Add chromaprint.
  2016-10-20  7:08   ` Hartmut Goebel
@ 2016-10-20 12:57     ` Ludovic Courtès
  0 siblings, 0 replies; 4+ messages in thread
From: Ludovic Courtès @ 2016-10-20 12:57 UTC (permalink / raw)
  To: Hartmut Goebel; +Cc: guix-devel

Hartmut Goebel <h.goebel@crazy-compilers.com> skribis:

> Am 19.10.2016 um 22:25 schrieb Ludovic Courtès:
>>> > +    (arguments
>>> > +     `(#:tests? #f ; tests require googletest *sources*
>> Weird.
>>
>
> Yes. From the issue I opened on this:[1]
>
>     That's the recommended way to use gtest. It's a C++ library and the
>     ABI depends on many compiler options. Debian based distributions
>     don't even ship a compiled package of gtest anymore.

Uh, interesting.  :-)

Maybe in a future patch we can unpack it there so we can run the tests
the way they recommend.

Thanks for the info,
Ludo’.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2016-10-20 12:57 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-26 18:19 [PATCH] gnu: Add chromaprint Hartmut Goebel
2016-10-19 20:25 ` Ludovic Courtès
2016-10-20  7:08   ` Hartmut Goebel
2016-10-20 12:57     ` Ludovic Courtès

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).