From: ludo@gnu.org (Ludovic Courtès)
To: guix-devel@gnu.org, Pierre Neidhardt <mail@ambrevar.xyz>
Subject: Re: 01/01: gnu: ccl: Include x86-headers and remove missing "contrib" folder.
Date: Tue, 20 Nov 2018 18:46:45 +0100 [thread overview]
Message-ID: <87sgzvy73u.fsf@gnu.org> (raw)
In-Reply-To: <20181118094018.8076B209C1@vcs0.savannah.gnu.org> (Pierre Neidhardt's message of "Sun, 18 Nov 2018 04:40:18 -0500 (EST)")
Hi Pierre,
mail@ambrevar.xyz (Pierre Neidhardt) skribis:
> commit d22ba64276c0bbacb77d0670635f67f053a16c6b
> Author: Pierre Neidhardt <mail@ambrevar.xyz>
> Date: Sun Nov 18 10:38:54 2018 +0100
>
> gnu: ccl: Include x86-headers and remove missing "contrib" folder.
>
> * gnu/packages/lisp.scm (ccl): Include x86-headers and remove missing "contrib" folder.
[...]
> + (let ((dirs '("lib" "library" "examples" "tools" "objc-bridge"
> + ,(match (%current-system)
> + ("x86_64-linux"
> + "x86-headers64")
> + ("i686-linux"
> + "x86-headers")))))
This lacks a clause for the other supported systems. This broke
evaluations of master on hydra & co., so I reverted this commit. Of
course you’re welcome to reinstate provided it passes on all platforms!
‘guix lint’ will now check that the package can be lowered to a
derivation for all the systems it claims to support (commit
3b32891b12ee18c57b0fc346ed7dce8b6976066b). So now it should be easier
to catch such issues.
Thanks,
Ludo’.
next parent reply other threads:[~2018-11-20 17:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20181118094017.18607.82174@vcs0.savannah.gnu.org>
[not found] ` <20181118094018.8076B209C1@vcs0.savannah.gnu.org>
2018-11-20 17:46 ` Ludovic Courtès [this message]
2018-11-20 18:49 ` 01/01: gnu: ccl: Include x86-headers and remove missing "contrib" folder Pierre Neidhardt
2018-11-22 9:18 ` Ludovic Courtès
2018-11-22 10:44 ` Pierre Neidhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sgzvy73u.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
--cc=mail@ambrevar.xyz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).