From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: 01/01: gnu: ccl: Include x86-headers and remove missing "contrib"
	folder.
Date: Tue, 20 Nov 2018 18:46:45 +0100
Message-ID: <87sgzvy73u.fsf@gnu.org>
References: <20181118094017.18607.82174@vcs0.savannah.gnu.org>
	<20181118094018.8076B209C1@vcs0.savannah.gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44129)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1gPA6v-0001VC-1X
	for guix-devel@gnu.org; Tue, 20 Nov 2018 12:46:54 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1gPA6t-00052Z-R9
	for guix-devel@gnu.org; Tue, 20 Nov 2018 12:46:52 -0500
In-Reply-To: <20181118094018.8076B209C1@vcs0.savannah.gnu.org> (Pierre
	Neidhardt's message of "Sun, 18 Nov 2018 04:40:18 -0500 (EST)")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: guix-devel@gnu.org, Pierre Neidhardt <mail@ambrevar.xyz>

Hi Pierre,

mail@ambrevar.xyz (Pierre Neidhardt) skribis:

> commit d22ba64276c0bbacb77d0670635f67f053a16c6b
> Author: Pierre Neidhardt <mail@ambrevar.xyz>
> Date:   Sun Nov 18 10:38:54 2018 +0100
>
>     gnu: ccl: Include x86-headers and remove missing "contrib" folder.
>=20=20=20=20=20
>     * gnu/packages/lisp.scm (ccl): Include x86-headers and remove missing=
 "contrib" folder.

[...]

> +               (let ((dirs '("lib" "library" "examples" "tools" "objc-br=
idge"
> +                             ,(match (%current-system)
> +                                ("x86_64-linux"
> +                                 "x86-headers64")
> +                                ("i686-linux"
> +                                 "x86-headers")))))

This lacks a clause for the other supported systems.  This broke
evaluations of master on hydra & co., so I reverted this commit.  Of
course you=E2=80=99re welcome to reinstate provided it passes on all platfo=
rms!

=E2=80=98guix lint=E2=80=99 will now check that the package can be lowered =
to a
derivation for all the systems it claims to support (commit
3b32891b12ee18c57b0fc346ed7dce8b6976066b).  So now it should be easier
to catch such issues.

Thanks,
Ludo=E2=80=99.