From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: Simon Tournier <zimon.toutoune@gmail.com>,
efraim@flashner.co.il, guix-devel <guix-devel@gnu.org>
Subject: Re: Feedback on indentation rules
Date: Fri, 17 Mar 2023 12:16:37 -0400 [thread overview]
Message-ID: <87sfe35p5m.fsf@gmail.com> (raw)
In-Reply-To: <8735662don.fsf@gnu.org> ("Ludovic Courtès"'s message of "Wed, 15 Mar 2023 17:15:52 +0100")
Hello,
Ludovic Courtès <ludo@gnu.org> writes:
> Hi,
>
> Simon Tournier <zimon.toutoune@gmail.com> skribis:
>
>> On Mon, 06 Mar 2023 at 17:56, Ludovic Courtès <ludo@gnu.org> wrote:
>>> Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:
>>>
>>>> Thanks for the feedback. I wonder if some are of the opinion that since
>>>> gexp->derivation is a plain function rather than a syntax having a
>>>> special form for its 2nd argument, we should leave the default
>>>> indentation rules untouched for it?
>>>
>>> Yes, that’s my take and current practice so far: special rules for
>>> special forms (macros), not for procedures.
>>
>> What is the rationale? Being able to know directly at the location when
>> it is a plain function or a special form?
>
> Yes.
>
> Now, it’s aesthetics so there’s no “rationale” per se but rather
> established practice: in the project, but also from what I can see in
> Guile and more generally Scheme (info "(guix) Formatting Code").
See commits d0b7858968a2c8c8cdacc3679447b250fb5b4dd9 and
933051281fbed0ae71bd40c24a701faf2a02791c, where I reverted to status quo
w.r.t. indentation rules of gexp->derivation and computed-file, given
the lack of clear consensus.
--
Thanks,
Maxim
prev parent reply other threads:[~2023-03-17 16:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230203221409.15886-2-maxim.cournoyer@gmail.com>
[not found] ` <20230203221409.15886-5-maxim.cournoyer@gmail.com>
[not found] ` <87357alp9n.fsf_-_@gnu.org>
[not found] ` <878rgxws6l.fsf@gmail.com>
[not found] ` <871qmg5qpj.fsf@gnu.org>
2023-02-23 22:20 ` Feedback on indentation rules (was: [PATCH 0/5] Add support for the RPM format to "guix pack") Maxim Cournoyer
2023-02-27 19:14 ` Efraim Flashner
2023-03-01 15:17 ` Feedback on indentation rules Maxim Cournoyer
2023-03-06 16:56 ` Ludovic Courtès
2023-03-07 13:46 ` Simon Tournier
2023-03-07 16:54 ` Maxim Cournoyer
2023-03-07 17:29 ` Simon Tournier
2023-03-09 13:55 ` Maxim Cournoyer
2023-03-15 16:15 ` Ludovic Courtès
2023-03-17 16:16 ` Maxim Cournoyer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sfe35p5m.fsf@gmail.com \
--to=maxim.cournoyer@gmail.com \
--cc=efraim@flashner.co.il \
--cc=guix-devel@gnu.org \
--cc=ludo@gnu.org \
--cc=zimon.toutoune@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).