From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Simon Tournier <zimon.toutoune@gmail.com>
Cc: "Ludovic Courtès" <ludo@gnu.org>,
efraim@flashner.co.il, guix-devel <guix-devel@gnu.org>
Subject: Re: Feedback on indentation rules
Date: Thu, 09 Mar 2023 08:55:28 -0500 [thread overview]
Message-ID: <87fsaet4fj.fsf@gmail.com> (raw)
In-Reply-To: <86wn3sa2rt.fsf@gmail.com> (Simon Tournier's message of "Tue, 07 Mar 2023 18:29:26 +0100")
Hi Simon,
Simon Tournier <zimon.toutoune@gmail.com> writes:
> Hi Maxim,
>
> On Tue, 07 Mar 2023 at 11:54, Maxim Cournoyer <maxim.cournoyer@gmail.com> wrote:
>
>>> For what it is worth, I do not see an high difference between the both
>>> indentations. So, my opinion would to keep the current practise.
>>
>> Please take a look at my original message in this thread,
>> https://lists.gnu.org/archive/html/guix-devel/2023-02/msg00297.html,
>> where I gave examples of gexp->derivation indentations that should
>> explain the rationale allow nesting arguments more naturally, as if
>> gexp->derivation was a special form (although it's a simple procedure).
>
> Yeah, I have read this rationale before. :-)
>
> My question was somehow directed to Ludo:
>
> > Yes, that’s my take and current practice so far: special rules for
> > special forms (macros), not for procedures.
>
> What is the rationale? Being able to know directly at the location when
> it is a plain function or a special form?
>
> Sorry for having been unclear.
>
> And I do not see a big difference between,
>
> (gexp->derivation "check-deb-pack"
> (with-imported-modules '((guix build utils))
>
> or
>
> (gexp->derivation "check-deb-pack"
> (with-imported-modules '((guix build utils))
>
> It is somehow personal cosmetic and I am sometimes poor person about
> cosmetic. ;-)
In the second case, we end up busting the 80 chars limit easily, so it
usually ends up formatted as:
--8<---------------cut here---------------start------------->8---
(gexp->derivation
"check-deb-pack"
(with-imported-modules '((guix build utils))
[...]
or
(define builder
#~(the builder code))
(gexp->derivation
"name"
builder)
--8<---------------cut here---------------end--------------->8---
Which is not very natural (in fact, I had found already used
indentation like 1) in tests/pack.scm before I adjusted the
.dir-locals.el file to match it, otherwise Emacs was re-indenting them
differently).
--
Thanks,
Maxim
next prev parent reply other threads:[~2023-03-09 13:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230203221409.15886-2-maxim.cournoyer@gmail.com>
[not found] ` <20230203221409.15886-5-maxim.cournoyer@gmail.com>
[not found] ` <87357alp9n.fsf_-_@gnu.org>
[not found] ` <878rgxws6l.fsf@gmail.com>
[not found] ` <871qmg5qpj.fsf@gnu.org>
2023-02-23 22:20 ` Feedback on indentation rules (was: [PATCH 0/5] Add support for the RPM format to "guix pack") Maxim Cournoyer
2023-02-27 19:14 ` Efraim Flashner
2023-03-01 15:17 ` Feedback on indentation rules Maxim Cournoyer
2023-03-06 16:56 ` Ludovic Courtès
2023-03-07 13:46 ` Simon Tournier
2023-03-07 16:54 ` Maxim Cournoyer
2023-03-07 17:29 ` Simon Tournier
2023-03-09 13:55 ` Maxim Cournoyer [this message]
2023-03-15 16:15 ` Ludovic Courtès
2023-03-17 16:16 ` Maxim Cournoyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fsaet4fj.fsf@gmail.com \
--to=maxim.cournoyer@gmail.com \
--cc=efraim@flashner.co.il \
--cc=guix-devel@gnu.org \
--cc=ludo@gnu.org \
--cc=zimon.toutoune@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).