From: Mark H Weaver <mhw@netris.org>
To: Chris Marusich <cmmarusich@gmail.com>, guix-devel@gnu.org
Subject: Re: core-updates: Emacs is only supported on x86_64-linux?
Date: Sun, 07 Mar 2021 05:46:24 -0500 [thread overview]
Message-ID: <87r1krgs10.fsf@netris.org> (raw)
In-Reply-To: <87a6rf5rd6.fsf@gmail.com>
Hi Chris,
Chris Marusich <cmmarusich@gmail.com> writes:
> I've noticed that the emacs package only supports x86_64-linux, at least
> on core-updates. Is that intended?
It's not intended. Emacs should certainly be supported on every system
that Guix supports.
> As for the cause, it looks like one contributing factor might be the
> rust package. It was recently added to the transitive closure of inputs
> of emacs. The rust package explicitly declares x86_64-linux as its only
> supported system. This restriction percolates up to emacs, and indeed
> to any other package that contains rust in its transitive closure of
> inputs.
Yes, exactly.
For now, I suggest that Emacs should have input 'librsvg' only on
'x86_64-linux' systems. Something like this (untested), for
core-updates:
--8<---------------cut here---------------start------------->8---
diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 98061c93ae..de6101cf17 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -71,6 +71,7 @@
#:use-module (gnu packages xml)
#:use-module (gnu packages xorg)
#:use-module (guix utils)
+ #:use-module (ice-9 match)
#:use-module (srfi srfi-1))
(define-public emacs
@@ -236,7 +237,10 @@
("libpng" ,libpng)
("zlib" ,zlib)
- ("librsvg" ,librsvg)
+ ,@(match (or (%current-target-system)
+ (%current-system))
+ ("x86_64-linux" `(("librsvg" ,librsvg)))
+ (_ `()))
("libxpm" ,libxpm)
("libxml2" ,libxml2)
("libice" ,libice)
--8<---------------cut here---------------end--------------->8---
Ditto for all other packages with 'librsvg' as an optional dependency.
> I noticed because it caused "make check" to fail on the wip-ppc64le
> branch (which is based on core-updates). I fixed one failing test on
> the wip-ppc64le branch by using coreutils instead of emacs in the test:
>
> https://git.savannah.gnu.org/cgit/guix.git/commit/?h=wip-ppc64le&id=1900a6227e99427cf3b28a86dbbee2c55f375f8c
>
> I suspect that - on core-updates, at least - Guix does not currently
> pass its "make check" test suite on any system other than x86_64-linux.
>
> I would like to cherry-pick the above fix onto core-updates. However,
> before doing that, I wanted to check on this list to see if anyone knew
> anything about the current situation. Is it intended that the emacs
> package only supports x86_64-linux?
While I'm not strongly opposed to the workaround above, it seems to me
the wrong fix. I think we should simply fix our Emacs package, as
outlined above. It should be easy.
What do you think? Would you like to try?
Mark
next prev parent reply other threads:[~2021-03-07 10:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-07 7:56 core-updates: Emacs is only supported on x86_64-linux? Chris Marusich
2021-03-07 10:46 ` Mark H Weaver [this message]
2021-03-07 23:40 ` Leo Famulari
2021-03-08 2:53 ` Chris Marusich
2021-03-08 5:29 ` Mark H Weaver
2021-03-08 7:14 ` Ricardo Wurmus
2021-03-10 0:09 ` Mark H Weaver
2021-03-08 7:19 ` Ricardo Wurmus
2021-03-09 6:04 ` Chris Marusich
2021-03-09 8:20 ` Chris Marusich
2021-03-10 0:05 ` Mark H Weaver
2021-03-08 22:33 ` Christopher Baines
2021-03-09 23:47 ` Mark H Weaver
2021-03-07 13:41 ` Christopher Baines
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r1krgs10.fsf@netris.org \
--to=mhw@netris.org \
--cc=cmmarusich@gmail.com \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).