From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 8HMoN2mvRGD3ZAAA0tVLHw (envelope-from ) for ; Sun, 07 Mar 2021 10:48:09 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id yA3jMmmvRGBRSwAAB5/wlQ (envelope-from ) for ; Sun, 07 Mar 2021 10:48:09 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2D4381D4AB for ; Sun, 7 Mar 2021 11:48:08 +0100 (CET) Received: from localhost ([::1]:43392 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lIqxE-000242-1c for larch@yhetil.org; Sun, 07 Mar 2021 05:48:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:56622) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lIqx0-00022f-SG for guix-devel@gnu.org; Sun, 07 Mar 2021 05:47:54 -0500 Received: from world.peace.net ([64.112.178.59]:36434) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lIqwy-0000P6-Ui for guix-devel@gnu.org; Sun, 07 Mar 2021 05:47:54 -0500 Received: from mhw by world.peace.net with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lIqww-0002fd-Ni; Sun, 07 Mar 2021 05:47:50 -0500 From: Mark H Weaver To: Chris Marusich , guix-devel@gnu.org Subject: Re: core-updates: Emacs is only supported on x86_64-linux? In-Reply-To: <87a6rf5rd6.fsf@gmail.com> References: <87a6rf5rd6.fsf@gmail.com> Date: Sun, 07 Mar 2021 05:46:24 -0500 Message-ID: <87r1krgs10.fsf@netris.org> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=64.112.178.59; envelope-from=mhw@netris.org; helo=world.peace.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1615114089; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=NY5kAhgkcwSYF3itgdCaSPS+hchY3+f09CS/ErEhRqo=; b=UdZ5MsBDF4zSWnFDQbMOuvgwSNdQJ1H8Svg5bSyb6gQYNd5isjeZiWtQ+SI3KdBPS7ZUVC rtaTl/hOz9sIRqa6TpLpnMTUEvZpIftqKeOUmnudSwyoBB6fv9jm4xG1//ZJj8oD8IoANe ILp4H9FSvin4vDgzzxs9eWxbqtPnVWPpqtf4eLnTWB20jyGet0D7xVfPH9bpJbkzjn0CLN S8q1JQtuCw2ulwnhLErShtT6LSvS3s9IaUe7HNPfqOXf1zfglXtdvBBwJvUUfOO/X8iFKI Ounc/VcTQcx/vSC8u7EiT92B4vdK6IIiET7Dgvp4/pfnfUMtE0PV6BnbSP/GXQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1615114089; a=rsa-sha256; cv=none; b=OpRM5imx/DEecMklULP/98f2PeLB6r4tfaciFjX7N6p5rhbHQIxDcYlhrYQBp6qGM93izN vSp/2VhyU9E15QBQLayb4rRKG9e5HXlm6kaRf7Jubz9+5QU0t8Zf8D9OBc6rNX4No6z9xL jJZzQ8SdlClE2sg4hCZZzFgFfKHKd15Vlhrq+L1TOwU0fPNE9EuSCLhVW88V6brmVb72W/ UnbfqOGC/4/AJ+2CFsGFcBh/BLvVihPH8PjEcG1faCff/fKCy+h/6srqj6gLLw5/O/Oa6J 0+8A41/NJ1Yob8ZtVF9Rp5IPozmyQ4Vqr8V1Ay1KF/i/yeXOaYV/mtWNNtIXTQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Spam-Score: -1.37 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Queue-Id: 2D4381D4AB X-Spam-Score: -1.37 X-Migadu-Scanner: scn0.migadu.com X-TUID: WqTf5dMLo2bV Hi Chris, Chris Marusich writes: > I've noticed that the emacs package only supports x86_64-linux, at least > on core-updates. Is that intended? It's not intended. Emacs should certainly be supported on every system that Guix supports. > As for the cause, it looks like one contributing factor might be the > rust package. It was recently added to the transitive closure of inputs > of emacs. The rust package explicitly declares x86_64-linux as its only > supported system. This restriction percolates up to emacs, and indeed > to any other package that contains rust in its transitive closure of > inputs. Yes, exactly. For now, I suggest that Emacs should have input 'librsvg' only on 'x86_64-linux' systems. Something like this (untested), for core-updates: --8<---------------cut here---------------start------------->8--- diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm index 98061c93ae..de6101cf17 100644 --- a/gnu/packages/emacs.scm +++ b/gnu/packages/emacs.scm @@ -71,6 +71,7 @@ #:use-module (gnu packages xml) #:use-module (gnu packages xorg) #:use-module (guix utils) + #:use-module (ice-9 match) #:use-module (srfi srfi-1)) (define-public emacs @@ -236,7 +237,10 @@ ("libpng" ,libpng) ("zlib" ,zlib) - ("librsvg" ,librsvg) + ,@(match (or (%current-target-system) + (%current-system)) + ("x86_64-linux" `(("librsvg" ,librsvg))) + (_ `())) ("libxpm" ,libxpm) ("libxml2" ,libxml2) ("libice" ,libice) --8<---------------cut here---------------end--------------->8--- Ditto for all other packages with 'librsvg' as an optional dependency. > I noticed because it caused "make check" to fail on the wip-ppc64le > branch (which is based on core-updates). I fixed one failing test on > the wip-ppc64le branch by using coreutils instead of emacs in the test: > > https://git.savannah.gnu.org/cgit/guix.git/commit/?h=wip-ppc64le&id=1900a6227e99427cf3b28a86dbbee2c55f375f8c > > I suspect that - on core-updates, at least - Guix does not currently > pass its "make check" test suite on any system other than x86_64-linux. > > I would like to cherry-pick the above fix onto core-updates. However, > before doing that, I wanted to check on this list to see if anyone knew > anything about the current situation. Is it intended that the emacs > package only supports x86_64-linux? While I'm not strongly opposed to the workaround above, it seems to me the wrong fix. I think we should simply fix our Emacs package, as outlined above. It should be easy. What do you think? Would you like to try? Mark