From: "Ludovic Courtès" <ludo@gnu.org>
To: "Bastien Rivière" <me@babariviere.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] service: systemd: use correct format for LISTEN_FDNAMES
Date: Sun, 08 May 2022 01:17:05 +0200 [thread overview]
Message-ID: <87r155x79q.fsf@gnu.org> (raw)
In-Reply-To: <e474bbc4-54bb-443b-9c53-800f083d36e7@www.fastmail.com> ("Bastien Rivière"'s message of "Sat, 07 May 2022 01:14:24 +0200")
Hi Bastien,
Bastien Rivière <me@babariviere.com> skribis:
> From fdabd4ee6d43e32cbf9bd85282ff66138ce652b9 Mon Sep 17 00:00:00 2001
> From: Bastien Riviere <me@babariviere.com>
> Date: Sat, 7 May 2022 01:08:28 +0200
> Subject: [PATCH] service: systemd: use correct format for LISTEN_FDNAMES
>
> As in the documentation, LISTEN_FDNAMES is expected to be a "colon-separated
> list of names".
> This patch add the missing delimiter when joining to LISTEN_FDNAMES.
>
> This fixes issues with services, like gpg-agent, which produces this kind of
> error:
>
>> [gpg-agent] Fatal: number of items in LISTEN_FDNAMES (1) does not match LISTEN_FDS (4) in --supervised mode
> ---
> modules/shepherd/service.scm | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
Good catch. I tweaked the commit log and pushed it as
74817c475b4d66923df89802e50666257dc82a68.
Thank you!
Ludo’.
prev parent reply other threads:[~2022-05-07 23:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-06 23:14 [PATCH] service: systemd: use correct format for LISTEN_FDNAMES Bastien Rivière
2022-05-07 23:17 ` Ludovic Courtès [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r155x79q.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
--cc=me@babariviere.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).