From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id kCKWFh3+dmKSHAAAbAwnHQ (envelope-from ) for ; Sun, 08 May 2022 01:17:49 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id aLC9FR3+dmItdgEAG6o9tA (envelope-from ) for ; Sun, 08 May 2022 01:17:49 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 260732C15C for ; Sun, 8 May 2022 01:17:49 +0200 (CEST) Received: from localhost ([::1]:36830 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nnTgK-00087J-B6 for larch@yhetil.org; Sat, 07 May 2022 19:17:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46556) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nnTfk-00086x-0W for guix-devel@gnu.org; Sat, 07 May 2022 19:17:12 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:45486) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nnTfj-0001mU-Fe; Sat, 07 May 2022 19:17:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=7/i2Q+JlEX9+gnB9lwNN9B8p4WVwwfdHJmwEXFWnXoM=; b=ITHKXxWeoHwnqo7P1b8F qquRMOL+Ae51N+gJDdtZ90ljRm2el4s1SqzkVWhAa+SkfoeLp3TEENLplBaaLaMnMsPs42/EoiG6B Roalsrg3UtwoO1BR0DWUkteT7ZWU03x2XHjVYYvwpQRE4tN8v6qCTlHGCfG+jt83SJ4yffiSaGmsj vudyCD7qYnSrXNC1SB16m03aT9e49RULWRgxAzkF3/JFQF8jpYBLZTqCOTHQr4Lhlo8Og+Zrmo5Zf e1U7r+Fq8CzuLixeWCyOcPgU4r0IxGhQ1FdFWfLnSElspoRXpOozTvcYro4JIOSsCydZNYq8shwVA L7I3tWGbm5CUGw==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:55796 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nnTff-0004rX-Vh; Sat, 07 May 2022 19:17:11 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Bastien =?utf-8?Q?Rivi=C3=A8re?= Cc: guix-devel@gnu.org Subject: Re: [PATCH] service: systemd: use correct format for LISTEN_FDNAMES References: X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 19 =?utf-8?Q?Flor=C3=A9al?= an 230 de la =?utf-8?Q?R?= =?utf-8?Q?=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Sun, 08 May 2022 01:17:05 +0200 In-Reply-To: ("Bastien =?utf-8?Q?Rivi=C3=A8re=22's?= message of "Sat, 07 May 2022 01:14:24 +0200") Message-ID: <87r155x79q.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1651965469; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=7/i2Q+JlEX9+gnB9lwNN9B8p4WVwwfdHJmwEXFWnXoM=; b=d4Qp2gUl0PN3Mtt4EwONYo4RT55ao5klHMlvygVXQFb45QvOsTKT37vESDjhxjcJhkjpk8 GOcGOmK8eWQYf/4wT2SGLtFlKM2o7+MtXcp+oSZaTCDCAIBhg65VsbU266yYMhBhiMEUiH BXRwL0EYXwUQoYJdznwhdxTa0H7DwTMWUsyTx7xFS/hZNLZ8kFj7n4pnS+yih06d+++wNS PhpLUi7n3EkdJyAL9xGYlGvHWHAH7IdTw9+IsJy+jBlAbQgfZHjZ08ei61NqzYrv7vQ9H4 6vktYBYzNR0Qr3JbHXeNGYlvZkDipz1J1JIHNVYoV2v/mMPV0gId7m4W+X3bmg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1651965469; a=rsa-sha256; cv=none; b=cl+MRWUwuPQ9KNCHXl2VcyBMeMT8pdxeO6Trem8hEK5s+NeU+h2WJlZwiBym+4xQH0jZt0 EcMQ+vMOX4SeViL/Ciw2VUYDxtHcJjcIW8ZdGshNIwmFbyhE71NYZ4EIV9F97LNju3Vk00 uAwWzqvNcSZt1DJhvw2Ei/TWyARzQxHysjB9Rddz3Te28Swodzqz6OBz1jdyKn3yvz66+Q Xfr7K34SdjV+b90jry1RVPOtfmSqtOh+aL5QKH1gPtLikGmbHcYXCDM4WcIZzqHpPGchu9 kzlW87Itdai66gG3vJqQlvAPkgD2FBxLxiF4C/VF13agsm/MMqBN7ZvhRaJurQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gnu.org header.s=fencepost-gnu-org header.b=ITHKXxWe; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -7.00 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gnu.org header.s=fencepost-gnu-org header.b=ITHKXxWe; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 260732C15C X-Spam-Score: -7.00 X-Migadu-Scanner: scn0.migadu.com X-TUID: +anziE8cOydA Hi Bastien, Bastien Rivi=C3=A8re skribis: > From fdabd4ee6d43e32cbf9bd85282ff66138ce652b9 Mon Sep 17 00:00:00 2001 > From: Bastien Riviere > Date: Sat, 7 May 2022 01:08:28 +0200 > Subject: [PATCH] service: systemd: use correct format for LISTEN_FDNAMES > > As in the documentation, LISTEN_FDNAMES is expected to be a "colon-separa= ted > list of names". > This patch add the missing delimiter when joining to LISTEN_FDNAMES. > > This fixes issues with services, like gpg-agent, which produces this kind= of > error: > >> [gpg-agent] Fatal: number of items in LISTEN_FDNAMES (1) does not match = LISTEN_FDS (4) in --supervised mode > --- > modules/shepherd/service.scm | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) Good catch. I tweaked the commit log and pushed it as 74817c475b4d66923df89802e50666257dc82a68. Thank you! Ludo=E2=80=99.