From: ludo@gnu.org (Ludovic Courtès)
To: Cyril Roelandt <tipecaml@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH v3 1/2] guix ui: add the "depends" field to package->recutils:
Date: Mon, 21 Jul 2014 17:51:45 +0200 [thread overview]
Message-ID: <87ppgy6772.fsf@gnu.org> (raw)
In-Reply-To: <1405900094-19802-1-git-send-email-tipecaml@gmail.com> (Cyril Roelandt's message of "Mon, 21 Jul 2014 01:48:14 +0200")
Cyril Roelandt <tipecaml@gmail.com> skribis:
> * guix/packages.scm (package-direct-inputs): New procedure.
> * tests/packages.scm: Test it.
> * guix/ui.scm (package->recutils): Print the dependencies of the package.
OK! “ui:” is enough in the subject line.
> + (format port "depends: ~a~%"
> + (match (package-direct-inputs p)
> + (((labels packages) ...)
> + (string-join (map package-full-name (sort packages package<?)) ", "))))
Please align “(match” with “port”.
Also, I think “dependencies” would be more consistent than “depends”
(sorry I didn’t catch it before.) Could you make that change?
OK to commit with these changes.
Thank you!
Ludo’.
next prev parent reply other threads:[~2014-07-21 15:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-13 18:54 [PATCH] guix package: add a "show" option Cyril Roelandt
2014-07-13 21:32 ` Ludovic Courtès
2014-07-14 8:41 ` Andreas Enge
2014-07-14 8:47 ` Alex Sassmannshausen
2014-07-14 9:03 ` John Darrington
2014-07-15 21:23 ` Ludovic Courtès
2014-07-17 0:54 ` [PATCH v2 1/2] guix ui: add the "depends" field to package->recutils: Cyril Roelandt
2014-07-17 0:54 ` [PATCH v2 2/2] guix package: add a "show" option Cyril Roelandt
2014-07-17 23:30 ` Ludovic Courtès
2014-07-17 23:26 ` [PATCH v2 1/2] guix ui: add the "depends" field to package->recutils: Ludovic Courtès
2014-07-20 23:48 ` [PATCH v3 " Cyril Roelandt
2014-07-21 15:51 ` Ludovic Courtès [this message]
2014-07-20 23:49 ` [PATCH v2 " Cyril Roelandt
2014-07-21 15:53 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ppgy6772.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
--cc=tipecaml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).