From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH v3 1/2] guix ui: add the "depends" field to
	package->recutils:
Date: Mon, 21 Jul 2014 17:51:45 +0200
Message-ID: <87ppgy6772.fsf@gnu.org>
References: <87mwc7bm96.fsf@gnu.org>
	<1405900094-19802-1-git-send-email-tipecaml@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37339)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1X9Fsc-000086-Ht
	for guix-devel@gnu.org; Mon, 21 Jul 2014 11:52:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1X9FsT-0000go-FJ
	for guix-devel@gnu.org; Mon, 21 Jul 2014 11:51:58 -0400
Received: from hera.aquilenet.fr ([2a01:474::1]:37005)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1X9FsT-0000gU-7a
	for guix-devel@gnu.org; Mon, 21 Jul 2014 11:51:49 -0400
In-Reply-To: <1405900094-19802-1-git-send-email-tipecaml@gmail.com> (Cyril
	Roelandt's message of "Mon, 21 Jul 2014 01:48:14 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Cyril Roelandt <tipecaml@gmail.com>
Cc: guix-devel@gnu.org

Cyril Roelandt <tipecaml@gmail.com> skribis:

> * guix/packages.scm (package-direct-inputs): New procedure.
> * tests/packages.scm: Test it.
> * guix/ui.scm (package->recutils): Print the dependencies of the package.

OK!  =E2=80=9Cui:=E2=80=9D is enough in the subject line.

> +  (format port "depends: ~a~%"
> +     (match (package-direct-inputs p)
> +       (((labels packages) ...)
> +        (string-join (map package-full-name (sort packages package<?)) "=
, "))))

Please align =E2=80=9C(match=E2=80=9D with =E2=80=9Cport=E2=80=9D.

Also, I think =E2=80=9Cdependencies=E2=80=9D would be more consistent than =
=E2=80=9Cdepends=E2=80=9D
(sorry I didn=E2=80=99t catch it before.)  Could you make that change?

OK to commit with these changes.

Thank you!

Ludo=E2=80=99.