unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: David Thompson <dthompson2@worcester.edu>
To: "Christopher Allan Webber" <cwebber@dustycloud.org>,
	宋文武 <iyzsong@gmail.com>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH] Add extremetuxracer (Note: needs help!)
Date: Mon, 27 Apr 2015 14:14:26 -0400	[thread overview]
Message-ID: <87pp6p781p.fsf@fsf.org> (raw)
In-Reply-To: <87mw1tikxb.fsf@earlgrey.lan>

Christopher Allan Webber <cwebber@dustycloud.org> writes:

> Christopher Allan Webber writes:
>
>> 宋文武 writes:
>>
>>>>   make[1]: *** [all-recursive] Error 1
>>>>   make[1]: Leaving directory '/tmp/nix-build-extremetuxracer-0.6.0.drv-0/etr-0.6.0'
>>>>   Makefile:457: recipe for target 'all' failed
>>>>   make: *** [all] Error 2
>>>>
>>>> sdl is an input, so I don't know what's going on...
>>>>
>>>> Sorry!  I thought this one was going to be an easy package that I
>>>> wouldn't need much help on!
>>> oops, I take a deep look.  It turn out that
>>> this package set the flags (for SDL, etc.) as 'CFLAGS',
>>> but it only use 'CXXFLAGS' (only have freetype) when compile cpp files.
>>> I think we can patch the Makefile after 'configure' phase, by:
>>>
>>>   (substitute* "Makefile"
>>>     (("CXXFLAGS =") "CXXFLAGS = ${CFLAGS)"))
>>>
>>> And better, ask upstream for a real fix :-)
>>
>> Spot on!  (Well mostly!  ${CFLAGS} not ${CFLAGS), I was confused for a
>> minute :))  But this was exactly what was needed!  We now have a working
>> (extreme) tuxracer!
>>
>> We're a REAL distro now!
>>  - cwebb
>
> Okay, Dave Thompson pointed out I should use modify-phases.  Done!

Pushed.  Thanks!

-- 
David Thompson
Web Developer - Free Software Foundation - http://fsf.org
GPG Key: 0FF1D807
Support the FSF: https://fsf.org/donate

      reply	other threads:[~2015-04-27 18:14 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-27  4:42 [PATCH] Add extremetuxracer (Note: needs help!) Christopher Allan Webber
2015-04-27  5:23 ` 宋文武
2015-04-27 13:23   ` Christopher Allan Webber
2015-04-27 14:18     ` David Thompson
2015-04-27 14:43     ` 宋文武
2015-04-27 16:23       ` Christopher Allan Webber
2015-04-27 16:40         ` Christopher Allan Webber
2015-04-27 18:14           ` David Thompson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pp6p781p.fsf@fsf.org \
    --to=dthompson2@worcester.edu \
    --cc=cwebber@dustycloud.org \
    --cc=guix-devel@gnu.org \
    --cc=iyzsong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).