From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Thompson Subject: Re: [PATCH] Add extremetuxracer (Note: needs help!) Date: Mon, 27 Apr 2015 14:14:26 -0400 Message-ID: <87pp6p781p.fsf@fsf.org> References: <87sibmi38e.fsf@earlgrey.lan> <878udexhxz.fsf@gmail.com> <87pp6pitxb.fsf@earlgrey.lan> <874mo11vjj.fsf@gmail.com> <87oam9ilo5.fsf@earlgrey.lan> <87mw1tikxb.fsf@earlgrey.lan> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:37818) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YmnY6-0006nh-6A for guix-devel@gnu.org; Mon, 27 Apr 2015 14:14:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YmnY5-0006vy-5d for guix-devel@gnu.org; Mon, 27 Apr 2015 14:14:30 -0400 Received: from mail.fsf.org ([208.118.235.13]:38542) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YmnY5-0006vs-2N for guix-devel@gnu.org; Mon, 27 Apr 2015 14:14:29 -0400 In-Reply-To: <87mw1tikxb.fsf@earlgrey.lan> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Christopher Allan Webber , =?utf-8?B?5a6L5paH?= =?utf-8?B?5q2m?= Cc: guix-devel Christopher Allan Webber writes: > Christopher Allan Webber writes: > >> =E5=AE=8B=E6=96=87=E6=AD=A6 writes: >> >>>> make[1]: *** [all-recursive] Error 1 >>>> make[1]: Leaving directory '/tmp/nix-build-extremetuxracer-0.6.0.drv= -0/etr-0.6.0' >>>> Makefile:457: recipe for target 'all' failed >>>> make: *** [all] Error 2 >>>> >>>> sdl is an input, so I don't know what's going on... >>>> >>>> Sorry! I thought this one was going to be an easy package that I >>>> wouldn't need much help on! >>> oops, I take a deep look. It turn out that >>> this package set the flags (for SDL, etc.) as 'CFLAGS', >>> but it only use 'CXXFLAGS' (only have freetype) when compile cpp files. >>> I think we can patch the Makefile after 'configure' phase, by: >>> >>> (substitute* "Makefile" >>> (("CXXFLAGS =3D") "CXXFLAGS =3D ${CFLAGS)")) >>> >>> And better, ask upstream for a real fix :-) >> >> Spot on! (Well mostly! ${CFLAGS} not ${CFLAGS), I was confused for a >> minute :)) But this was exactly what was needed! We now have a working >> (extreme) tuxracer! >> >> We're a REAL distro now! >> - cwebb > > Okay, Dave Thompson pointed out I should use modify-phases. Done! Pushed. Thanks! --=20 David Thompson Web Developer - Free Software Foundation - http://fsf.org GPG Key: 0FF1D807 Support the FSF: https://fsf.org/donate