Re: [PATCH 0/1] Add lz4 (C implementation)

[ludo@gnu.org (Ludovic Courtès)]

Leo Famulari <leo@famulari.name> skribis:

> I'm looking for advice regarding the tests. The tests take >30 minutes on my on
> my quad-core i5 with 8 gigabytes of RAM and they require Valgrind as a
> native-input. This seems excessive to me but if users install binary
> substitutes, they won't run the tests or need to install Valgrind, right? And 
> if distributions won't test software, then who will?

Indeed, I think it’s fine.  As Taylan noted, there are already several
cases of long test suites.

> +    (name "lz4")
> +    (version "r131")

I changed that to “131”, which conforms to the expectations of what a
version number is.  For instance:

--8<---------------cut here---------------start------------->8---
scheme@(guile-user)> (package-name->name+version "lz4-r131")
$3 = "lz4-r131"
$4 = #f
scheme@(guile-user)> (package-name->name+version "lz4-131")
$5 = "lz4"
$6 = "131"
--8<---------------cut here---------------end--------------->8---


> +     (origin
> +       (method url-fetch)
> +       (uri (string-append "https://github.com/Cyan4973/lz4/archive/"
> +                            version ".tar.gz"))
> +       (sha256
> +        (base32 "1vfg305zvj50hwscad24wan9jar6nqj14gdk2hqyr7bb9mhh0kcx"))))

Added a ‘file-name’ field here so we get “lz4-131.tar.gz” instead of
“r131.tar.gz” (this is purely cosmetic; no functional change.)

Thanks!

Ludo’.