From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 0/1] Add lz4 (C implementation)
Date: Sun, 13 Sep 2015 12:10:21 +0200
Message-ID: <87pp1m7hpu.fsf@gnu.org>
References: <cover.1441832565.git.leo@famulari.name>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44939)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Zb4Et-0002PL-J1
	for guix-devel@gnu.org; Sun, 13 Sep 2015 06:10:28 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Zb4Eq-0000ao-7U
	for guix-devel@gnu.org; Sun, 13 Sep 2015 06:10:27 -0400
In-Reply-To: <cover.1441832565.git.leo@famulari.name> (Leo Famulari's message
	of "Wed, 9 Sep 2015 17:04:11 -0400")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Leo Famulari <leo@famulari.name>
Cc: guix-devel@gnu.org

Leo Famulari <leo@famulari.name> skribis:

> I'm looking for advice regarding the tests. The tests take >30 minutes on=
 my on
> my quad-core i5 with 8 gigabytes of RAM and they require Valgrind as a
> native-input. This seems excessive to me but if users install binary
> substitutes, they won't run the tests or need to install Valgrind, right?=
 And=20
> if distributions won't test software, then who will?

Indeed, I think it=E2=80=99s fine.  As Taylan noted, there are already seve=
ral
cases of long test suites.

> +    (name "lz4")
> +    (version "r131")

I changed that to =E2=80=9C131=E2=80=9D, which conforms to the expectations=
 of what a
version number is.  For instance:

--8<---------------cut here---------------start------------->8---
scheme@(guile-user)> (package-name->name+version "lz4-r131")
$3 =3D "lz4-r131"
$4 =3D #f
scheme@(guile-user)> (package-name->name+version "lz4-131")
$5 =3D "lz4"
$6 =3D "131"
--8<---------------cut here---------------end--------------->8---


> +     (origin
> +       (method url-fetch)
> +       (uri (string-append "https://github.com/Cyan4973/lz4/archive/"
> +                            version ".tar.gz"))
> +       (sha256
> +        (base32 "1vfg305zvj50hwscad24wan9jar6nqj14gdk2hqyr7bb9mhh0kcx"))=
))

Added a =E2=80=98file-name=E2=80=99 field here so we get =E2=80=9Clz4-131.t=
ar.gz=E2=80=9D instead of
=E2=80=9Cr131.tar.gz=E2=80=9D (this is purely cosmetic; no functional chang=
e.)

Thanks!

Ludo=E2=80=99.