unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Re: 01/01: gnu: vlc: Update to 2.2.4 [fixes CVE-2016-5108].
       [not found] ` <20160608141209.0462E220074@vcs.savannah.gnu.org>
@ 2016-06-08 15:23   ` Ludovic Courtès
  0 siblings, 0 replies; only message in thread
From: Ludovic Courtès @ 2016-06-08 15:23 UTC (permalink / raw)
  To: Efraim Flashner; +Cc: guix-devel

efraim@flashner.co.il (Efraim Flashner) skribis:

> commit a134cc8e93428bf6f309de54e5c944705d30418f
> Author: Efraim Flashner <efraim@flashner.co.il>
> Date:   Wed Jun 8 17:11:06 2016 +0300
>
>     gnu: vlc: Update to 2.2.4 [fixes CVE-2016-5108].
>     
>     * gnu/packages/video.scm (vlc): Update to 2.2.4.
>     [inputs]: Remove qt, add qtbase.

IMO it would have been best to make it two separate patches.

>     [arguments]: Add phase to disable display test.

> +         (add-before 'configure 'remove-visual-tests
> +           ;; Some of the tests require using the display to test out VLC,
> +           ;; which fails in our sandboxed build system

Usually this is addressed by starting Xvfb (there are several examples
of that.)  Would it work here?

> +             (substitute* "test/run_vlc.sh"
> +                          (("./vlc --ignore-config") "echo"))

What happened with indentation?  :-)

Thanks for the security update!

Ludo’.

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2016-06-08 15:23 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20160608141208.26176.89429@vcs.savannah.gnu.org>
     [not found] ` <20160608141209.0462E220074@vcs.savannah.gnu.org>
2016-06-08 15:23   ` 01/01: gnu: vlc: Update to 2.2.4 [fixes CVE-2016-5108] Ludovic Courtès

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).