Re: 05/06: gnu: wget: Add wget2.

Re: 05/06: gnu: wget: Add wget2.

[Mark H Weaver]

ludo@gnu.org (Ludovic Courtès) writes:

> civodul pushed a commit to branch master
> in repository guix.
>
> commit afc438231623fceb4ec8f3aa2f8c4e8f99a3ec22
> Author: Rutger Helling <rhelling@mykolab.com>
> Date:   Tue Nov 14 19:01:08 2017 +0100
>
>     gnu: wget: Add wget2.
>     
>     * gnu/packages/wget.scm (wget2): New variable.
>     
>     Signed-off-by: Ludovic Courtès <ludo@gnu.org>

[...]

> +   (home-page "https://github.com/rockdaboot/wget2")
> +   (synopsis "Successor of GNU Wget")
> +   (description "GNU Wget2 is the successor of GNU Wget, a file and recursive
> +website downloader.  Designed and written from scratch it wraps around libwget,
> +that provides the basic functions needed by a web client.")
> +   (license (list gpl3+ lgpl3+))))

I was curious about this claim "Successor of GNU Wget", so I looked at
the canonical GNU Wget site:

  https://gnu.org/s/wget

which states:

  Currently GNU Wget2 is being developed.  Please help us if you can
  with testing, docs, organization, development, ... see you at Wget2
  collaboration site <https://gitlab.com/gnuwget/wget2>

For the source and home-page URLs, I would prefer to promote the gitlab
site over the github one, especially since that's the one referenced
from <https://gnu.org/s/wget>.

What do you think?

      Mark

Re: 05/06: gnu: wget: Add wget2.

[Rutger Helling]

[-- Attachment #1.1: Type: text/plain, Size: 1515 bytes --]

Hi Mark and Ludo, 

I wrote a small patch that switches to the official mirror. 

On 2017-11-16 23:22, Mark H Weaver wrote:

> ludo@gnu.org (Ludovic Courtès) writes:
> 
>> civodul pushed a commit to branch master
>> in repository guix.
>> 
>> commit afc438231623fceb4ec8f3aa2f8c4e8f99a3ec22
>> Author: Rutger Helling <rhelling@mykolab.com>
>> Date:   Tue Nov 14 19:01:08 2017 +0100
>> 
>> gnu: wget: Add wget2.
>> 
>> * gnu/packages/wget.scm (wget2): New variable.
>> 
>> Signed-off-by: Ludovic Courtès <ludo@gnu.org>
> 
> [...]
> 
>> +   (home-page "https://github.com/rockdaboot/wget2")
>> +   (synopsis "Successor of GNU Wget")
>> +   (description "GNU Wget2 is the successor of GNU Wget, a file and recursive
>> +website downloader.  Designed and written from scratch it wraps around libwget,
>> +that provides the basic functions needed by a web client.")
>> +   (license (list gpl3+ lgpl3+))))
> 
> I was curious about this claim "Successor of GNU Wget", so I looked at
> the canonical GNU Wget site:
> 
> https://gnu.org/s/wget
> 
> which states:
> 
> Currently GNU Wget2 is being developed.  Please help us if you can
> with testing, docs, organization, development, ... see you at Wget2
> collaboration site <https://gitlab.com/gnuwget/wget2>
> 
> For the source and home-page URLs, I would prefer to promote the gitlab
> site over the github one, especially since that's the one referenced
> from <https://gnu.org/s/wget>.
> 
> What do you think?
> 
> Mark

[-- Attachment #1.2: Type: text/html, Size: 3026 bytes --]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-wget-Switch-to-official-URL.patch --]
[-- Type: text/x-diff; name=0001-gnu-wget-Switch-to-official-URL.patch, Size: 927 bytes --]

From 18d5e35e56f4c34ad0e55cee18eef86b8ea2d5f9 Mon Sep 17 00:00:00 2001
From: Rutger Helling <rhelling@mykolab.com>
Date: Fri, 17 Nov 2017 08:29:10 +0100
Subject: [PATCH] gnu: wget2: Switch to official URL.

* gnu/packages/wget.scm (wget2): Switch to official URL.
---
 gnu/packages/wget.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/wget.scm b/gnu/packages/wget.scm
index a4862d515..bc3b3ad5d 100644
--- a/gnu/packages/wget.scm
+++ b/gnu/packages/wget.scm
@@ -130,7 +130,7 @@ online pastebin services.")
     (origin
      (method git-fetch)
      (uri (git-reference
-           (url "https://github.com/rockdaboot/wget2")
+           (url "https://gitlab.com/gnuwget/wget2.git")
            (commit "b45709d3d21714135ce79df6abbdcb704684063d")
            (recursive? #t))) ;; Needed for 'gnulib' git submodule.
      (file-name (string-append name "-" version "-checkout"))
-- 
2.15.0

Re: 05/06: gnu: wget: Add wget2.

[Mark H Weaver]

Hi,

Rutger Helling <rhelling@mykolab.com> writes:
> I wrote a small patch that switches to the official mirror.

Your patch changes the source URI, but not the home-page.  Would you
like to update your patch to change the home-page too?

      Mark


> From 18d5e35e56f4c34ad0e55cee18eef86b8ea2d5f9 Mon Sep 17 00:00:00 2001
> From: Rutger Helling <rhelling@mykolab.com>
> Date: Fri, 17 Nov 2017 08:29:10 +0100
> Subject: [PATCH] gnu: wget2: Switch to official URL.
>
> * gnu/packages/wget.scm (wget2): Switch to official URL.
> ---
>  gnu/packages/wget.scm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gnu/packages/wget.scm b/gnu/packages/wget.scm
> index a4862d515..bc3b3ad5d 100644
> --- a/gnu/packages/wget.scm
> +++ b/gnu/packages/wget.scm
> @@ -130,7 +130,7 @@ online pastebin services.")
>      (origin
>       (method git-fetch)
>       (uri (git-reference
> -           (url "https://github.com/rockdaboot/wget2")
> +           (url "https://gitlab.com/gnuwget/wget2.git")
>             (commit "b45709d3d21714135ce79df6abbdcb704684063d")
>             (recursive? #t))) ;; Needed for 'gnulib' git submodule.
>       (file-name (string-append name "-" version "-checkout"))

Re: 05/06: gnu: wget: Add wget2.

[Rutger Helling]

[-- Attachment #1.1: Type: text/plain, Size: 1264 bytes --]

Oops! Here's V2. 

On 2017-11-17 20:28, Mark H Weaver wrote:

> Hi,
> 
> Rutger Helling <rhelling@mykolab.com> writes: 
> 
>> I wrote a small patch that switches to the official mirror.
> 
> Your patch changes the source URI, but not the home-page.  Would you
> like to update your patch to change the home-page too?
> 
> Mark
> 
>> From 18d5e35e56f4c34ad0e55cee18eef86b8ea2d5f9 Mon Sep 17 00:00:00 2001
>> From: Rutger Helling <rhelling@mykolab.com>
>> Date: Fri, 17 Nov 2017 08:29:10 +0100
>> Subject: [PATCH] gnu: wget2: Switch to official URL.
>> 
>> * gnu/packages/wget.scm (wget2): Switch to official URL.
>> ---
>> gnu/packages/wget.scm | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/gnu/packages/wget.scm b/gnu/packages/wget.scm
>> index a4862d515..bc3b3ad5d 100644
>> --- a/gnu/packages/wget.scm
>> +++ b/gnu/packages/wget.scm
>> @@ -130,7 +130,7 @@ online pastebin services.")
>> (origin
>> (method git-fetch)
>> (uri (git-reference
>> -           (url "https://github.com/rockdaboot/wget2")
>> +           (url "https://gitlab.com/gnuwget/wget2.git")
>> (commit "b45709d3d21714135ce79df6abbdcb704684063d")
>> (recursive? #t))) ;; Needed for 'gnulib' git submodule.
>> (file-name (string-append name "-" version "-checkout"))

[-- Attachment #1.2: Type: text/html, Size: 2745 bytes --]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-wget2-Switch-to-official-URL-v2.patch --]
[-- Type: text/x-diff; name=0001-gnu-wget2-Switch-to-official-URL-v2.patch, Size: 1411 bytes --]

From 23fd827972f26c627f4da3a90d49cd2d398e1297 Mon Sep 17 00:00:00 2001
From: Rutger Helling <rhelling@mykolab.com>
Date: Fri, 17 Nov 2017 20:35:00 +0100
Subject: [PATCH] gnu: wget2: Switch to official URL.

* gnu/packages/wget.scm (wget2): Switch to official URL.
---
 gnu/packages/wget.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/wget.scm b/gnu/packages/wget.scm
index a4862d515..3dcf00b9b 100644
--- a/gnu/packages/wget.scm
+++ b/gnu/packages/wget.scm
@@ -130,7 +130,7 @@ online pastebin services.")
     (origin
      (method git-fetch)
      (uri (git-reference
-           (url "https://github.com/rockdaboot/wget2")
+           (url "https://gitlab.com/gnuwget/wget2.git")
            (commit "b45709d3d21714135ce79df6abbdcb704684063d")
            (recursive? #t))) ;; Needed for 'gnulib' git submodule.
      (file-name (string-append name "-" version "-checkout"))
@@ -167,7 +167,7 @@ online pastebin services.")
              ("python", python)))
    ;; TODO: Add libbrotlidec, libnghttp2.
    (native-inputs `(("pkg-config", pkg-config)))
-   (home-page "https://github.com/rockdaboot/wget2")
+   (home-page "https://gitlab.com/gnuwget/wget2")
    (synopsis "Successor of GNU Wget")
    (description "GNU Wget2 is the successor of GNU Wget, a file and recursive
 website downloader.  Designed and written from scratch it wraps around libwget,
-- 
2.15.0

Re: 05/06: gnu: wget: Add wget2.

[Ludovic Courtès]

Hi Rutger & Mark,

Rutger Helling <rhelling@mykolab.com> skribis:

> From 23fd827972f26c627f4da3a90d49cd2d398e1297 Mon Sep 17 00:00:00 2001
> From: Rutger Helling <rhelling@mykolab.com>
> Date: Fri, 17 Nov 2017 20:35:00 +0100
> Subject: [PATCH] gnu: wget2: Switch to official URL.
>
> * gnu/packages/wget.scm (wget2): Switch to official URL.

Applied, thanks!

Ludo’.