unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Mark H Weaver <mhw@netris.org>
Cc: guix-devel@gnu.org, Amin Bandali <bandali@gnu.org>
Subject: Re: [bug#42738] [PATCH v4] gnu: emacs: Update to 27.1.
Date: Mon, 07 Sep 2020 11:00:32 +0200	[thread overview]
Message-ID: <87pn6yotan.fsf@gnu.org> (raw)
In-Reply-To: <878sdxm84i.fsf@netris.org> (Mark H. Weaver's message of "Sat, 29 Aug 2020 17:53:06 -0400")

Hi Mark,

Mark H Weaver <mhw@netris.org> skribis:

> Ludovic Courtès <ludo@gnu.org> wrote:
>> Mark H Weaver <mhw@netris.org> skribis:
>>
>>> (define-public emacs-next
>>>   (let ((commit "c36c5a3dedbb2e0349be1b6c3b7567ea7b594f1c")
>>>         (revision "0")
>>>         (emacs-version "27.0.91"))
>>>     (package
>>>       (inherit emacs)
>>>       (name "emacs-next")
>>>       (version (git-version emacs-version revision commit))
>>>       (source
>>>        (origin
>>>          (inherit (package-source emacs))
>>>          (method git-fetch)
>>>          (uri (git-reference
>>>                (url "https://git.savannah.gnu.org/git/emacs.git")
>>>                (commit commit)))
>>
>> This can be handled with ‘--with-git-url’.
>
> I think that wouldn't work in this case, because we also need to
> preserve the existing 'patches' and 'snippet' fields, which I arranged
> to inherit above via (inherit (package-source emacs)).  That probably
> deserves a comment, since it's easily overlooked.
>
>>>          (sha256
>>>           (base32 "0mlrg2npy1r79laahkgzhxd1qassfcdz8qk1cpw7mqgf6y5x505h"))
>>>          (file-name (git-file-name name version))))
>>>       (native-inputs
>>>        `(("autoconf" ,autoconf)      ; needed when building from trunk
>>>          ,@(package-native-inputs emacs)))
>>
>> For this, we’d need a new ‘--with-extra-input’ package transformation
>> option or similar.  That way, we wouldn’t even need an ‘emacs-next’
>> package: people would just run
>>
>>   guix install emacs --with-git-url=… --with-extra-input=autoconf
>
> There's also the 'native-search-paths' field, which cannot simply be
> inherited because of the version number embedded within EMACSLOADPATH.
> This particular issue could be avoided if the 'native-search-paths'
> field were a function of the version number, but that raises migration
> issues and I'm not sure it's worth it.
>
> What do you think?

Ah yes, both good points that I had overlooked.

Thanks,
Ludo’.


  reply	other threads:[~2020-09-07  9:00 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20200819040941.32696-1-jackhill@jackhill.us>
     [not found] ` <DM5PR1001MB210589E35972B5314D4D8381C5550@DM5PR1001MB2105.namprd10.prod.outlook.com>
2020-08-28 14:18   ` [PATCH v4] gnu: emacs: Update to 27.1 Ludovic Courtès
2020-08-28 14:38     ` Pierre Neidhardt
2020-08-28 17:00     ` [bug#42738] " Brett Gilio
2020-08-28 17:08       ` Jack Hill
2020-08-28 17:34       ` Amin Bandali
2020-08-28 20:04         ` Mark H Weaver
2020-08-29 10:13           ` Ludovic Courtès
2020-08-29 21:53             ` Mark H Weaver
2020-09-07  9:00               ` Ludovic Courtès [this message]
2020-08-28 18:57     ` Mark H Weaver
2020-08-28 21:10       ` Morgan Smith
2020-08-29 20:35         ` Mark H Weaver
2020-08-30  1:50           ` [bug#42738] " Brett Gilio
2020-08-29 17:19       ` Giovanni Biscuolo
2020-09-04  9:03         ` Pierre Neidhardt
     [not found]           ` <87pn713nr7.fsf@ambrevar.xyz>
2020-09-04 10:20             ` Giovanni Biscuolo
2020-09-07  9:44               ` Pierre Neidhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pn6yotan.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=bandali@gnu.org \
    --cc=guix-devel@gnu.org \
    --cc=mhw@netris.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).