unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Mark H Weaver <mhw@netris.org>
To: Morgan Smith <Morgan.J.Smith@outlook.com>
Cc: guix-devel@gnu.org, 42738@debbugs.gnu.org
Subject: Re: [PATCH v4] gnu: emacs: Update to 27.1.
Date: Sat, 29 Aug 2020 16:35:54 -0400	[thread overview]
Message-ID: <87h7slmbp6.fsf@netris.org> (raw)
In-Reply-To: <DM5PR1001MB21050D5A7BEC8ADA8CCD852FC5520@DM5PR1001MB2105.namprd10.prod.outlook.com>

Hi Morgan,

Morgan Smith <Morgan.J.Smith@outlook.com> wrote:
> It seems I am taking some credit for Jack Hill's patch. I simply took
> Jack's patch (labeled as patch v3 in the debbugs thread) and attempted
> to build it with my personal config.

Indeed, I see that now.  Sorry for the mistake.  I suppose it happened
because it was presented to me as "the patch Morgan submitted", but it
would have been better if I had taken the time to read the bug report
more carefully.

Also, I regret if my comments on the preliminary patch made anyone feel
badly.  To be clear, there's no shame in submitting an unfinished patch
for review.  On the contrary, it is a *very* useful contribution.  In
this case, it makes sense to start by updating the main 'emacs' package,
and to worry about the other variants later.  There's no fault in that.

The only fault here lies with me.  I should have looked more carefully
for prior work, and I probably also pushed it prematurely.

> (Also just my 2 cents, we should have upgraded emacs-next to 27.1 and
> only upgraded emacs a week later. Emacs deserves more care than most
> packages due to its dependence on so many other packages. Not trying to
> shame anyone, just something to think of for next time.)

Agreed, or perhaps 'emacs' itself should have been updated on a separate
branch.  In the past, when this was a smaller community and there were
far fewer emacs packages in Guix, I did major updates of Emacs a few
times without causing any obvious problems, but that was a different
time.  It's also possible that Emacs 27 was a more disruptive update
than usual.

Thanks very much for your comments and contributions.

   Best regards,
       Mark


  reply	other threads:[~2020-08-29 20:37 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20200819040941.32696-1-jackhill@jackhill.us>
     [not found] ` <DM5PR1001MB210589E35972B5314D4D8381C5550@DM5PR1001MB2105.namprd10.prod.outlook.com>
2020-08-28 14:18   ` [PATCH v4] gnu: emacs: Update to 27.1 Ludovic Courtès
2020-08-28 14:38     ` Pierre Neidhardt
2020-08-28 17:00     ` [bug#42738] " Brett Gilio
2020-08-28 17:08       ` Jack Hill
2020-08-28 17:34       ` Amin Bandali
2020-08-28 20:04         ` Mark H Weaver
2020-08-29 10:13           ` Ludovic Courtès
2020-08-29 21:53             ` Mark H Weaver
2020-09-07  9:00               ` Ludovic Courtès
2020-08-28 18:57     ` Mark H Weaver
2020-08-28 21:10       ` Morgan Smith
2020-08-29 20:35         ` Mark H Weaver [this message]
2020-08-30  1:50           ` [bug#42738] " Brett Gilio
2020-08-29 17:19       ` Giovanni Biscuolo
2020-09-04  9:03         ` Pierre Neidhardt
     [not found]           ` <87pn713nr7.fsf@ambrevar.xyz>
2020-09-04 10:20             ` Giovanni Biscuolo
2020-09-07  9:44               ` Pierre Neidhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h7slmbp6.fsf@netris.org \
    --to=mhw@netris.org \
    --cc=42738@debbugs.gnu.org \
    --cc=Morgan.J.Smith@outlook.com \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).