[PATCH 2/2] gnu: Add libwnck

[PATCH 2/2] gnu: Add libwnck

[宋文武]

[-- Attachment #1: Type: text/plain, Size: 55 bytes --]

This is after: [PATCH]: gnu: Add startup-notification


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0002-gnu-Add-libwnck.patch --]
[-- Type: text/x-patch, Size: 2716 bytes --]

From 5383f469603146abc102f70165e2bea9538b3d34 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E5=AE=8B=E6=96=87=E6=AD=A6?= <iyzsong@gmail.com>
Date: Mon, 8 Dec 2014 23:00:41 +0800
Subject: [PATCH 2/2] gnu: Add libwnck.

* gnu/packages/gnome.scm (libwnck, libwnck-1): New variables.
---
 gnu/packages/gnome.scm | 46 +++++++++++++++++++++++++++++++++++++++++++++-
 1 file changed, 45 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 5fa892a..c2bd90c 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -46,7 +46,8 @@
   #:use-module (gnu packages xml)
   #:use-module (gnu packages gl)
   #:use-module (gnu packages compression)
-  #:use-module (gnu packages xorg))
+  #:use-module (gnu packages xorg)
+  #:use-module (gnu packages xdisorg))
 
 (define-public brasero
   (package
@@ -1119,6 +1120,49 @@ widgets built in the loading process.")
 controls using the Bonobo component framework.")
     (license license:lgpl2.0+)))
 
+(define-public libwnck
+  (package
+    (name "libwnck")
+    (version "3.14.0")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "mirror://gnome/sources/" name "/"
+                                  (version-major+minor version) "/"
+                                  name "-" version ".tar.xz"))
+              (sha256
+               (base32 "074jww04z8g9r1acndqap79wx4kbm3rpkf4lcg1v82b66iv0027m"))))
+    (build-system gnu-build-system)
+    (native-inputs
+     `(("pkg-config" ,pkg-config)
+       ("intltool" ,intltool)))
+    (propagated-inputs
+     `(("gtk+" ,gtk+)))
+    (inputs
+     `(("startup-notification" ,startup-notification)
+       ("libxres" ,libxres)))
+    (home-page "https://developer.gnome.org/libwnck/")
+    (synopsis "Window Navigator Construction Kit")
+    (description
+     "Libwnck is the Window Navigator Construction Kit, a library for use in
+writing pagers, tasklists, and more generally applications that are dealing
+with window management.  It tries hard to respect the Extended Window Manager
+Hints specification (EWMH).")
+    (license license:lgpl2.0+)))
+
+(define-public libwnck-1
+  (package (inherit libwnck)
+    (name "libwnck")
+    (version "2.30.7")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "mirror://gnome/sources/" name "/"
+                                  (version-major+minor version) "/"
+                                  name "-" version ".tar.xz"))
+              (sha256
+               (base32
+                "15713yl0f8f3p99jzqqfmbicrdswd3vwpx7r3bkf1bgh6d9lvs4b"))))
+    (propagated-inputs
+     `(("gtk+" ,gtk+-2)))))
 
 (define-public goffice
   (package
-- 
2.1.2

Re: [PATCH 2/2] gnu: Add libwnck

[Ludovic Courtès]

宋文武 <iyzsong@gmail.com> skribis:

> From 5383f469603146abc102f70165e2bea9538b3d34 Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?=E5=AE=8B=E6=96=87=E6=AD=A6?= <iyzsong@gmail.com>
> Date: Mon, 8 Dec 2014 23:00:41 +0800
> Subject: [PATCH 2/2] gnu: Add libwnck.
>
> * gnu/packages/gnome.scm (libwnck, libwnck-1): New variables.

[...]

> +(define-public libwnck-1
> +  (package (inherit libwnck)
> +    (name "libwnck")
> +    (version "2.30.7")

Could you add a comment saying why this version needs to be kept?

OK to push with that.

Thanks!

Ludo’.

Re: [PATCH 2/2] gnu: Add libwnck

[宋文武]

Ludovic Courtès <ludo@gnu.org> writes:

> 宋文武 <iyzsong@gmail.com> skribis:
>
>> From 5383f469603146abc102f70165e2bea9538b3d34 Mon Sep 17 00:00:00 2001
>> From: =?UTF-8?q?=E5=AE=8B=E6=96=87=E6=AD=A6?= <iyzsong@gmail.com>
>> Date: Mon, 8 Dec 2014 23:00:41 +0800
>> Subject: [PATCH 2/2] gnu: Add libwnck.
>>
>> * gnu/packages/gnome.scm (libwnck, libwnck-1): New variables.
>
> [...]
>
>> +(define-public libwnck-1
>> +  (package (inherit libwnck)
>> +    (name "libwnck")
>> +    (version "2.30.7")
>
> Could you add a comment saying why this version needs to be kept?
>
> OK to push with that.
Pushed, thanks for review.
>
> Thanks!
>
> Ludo’.