From: ludo@gnu.org (Ludovic Courtès)
To: Mathieu Lirzin <mthl@openmailbox.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] website : ...
Date: Fri, 08 May 2015 12:45:42 +0200 [thread overview]
Message-ID: <87oalvl549.fsf@gnu.org> (raw)
In-Reply-To: <87egmr7lro.fsf@openmailbox.org> (Mathieu Lirzin's message of "Fri, 08 May 2015 06:09:47 +0200")
Could you create yourself an account on Savannah so I can add you to the
project? That will make it easier to work on these changes.
Mathieu Lirzin <mthl@openmailbox.org> skribis:
> From 8d61be9cdd787265b7bb7e1232546f5e7f3997e3 Mon Sep 17 00:00:00 2001
> From: Mathieu Lirzin <mthl@openmailbox.org>
> Date: Thu, 7 May 2015 21:21:02 +0200
> Subject: [PATCH 1/3] website: Enable directory choice in export procedure.
OK.
> From 4763ec6706b9f5088b00f3b99f4e3eca57b05d8a Mon Sep 17 00:00:00 2001
> From: Mathieu Lirzin <mthl@openmailbox.org>
> Date: Fri, 8 May 2015 00:06:03 +0200
> Subject: [PATCH 2/3] website: Factorize shared blocks.
OK.
> From c36af581753b015f31a562d2fe8992465d15f36e Mon Sep 17 00:00:00 2001
> From: Mathieu Lirzin <mthl@openmailbox.org>
> Date: Fri, 8 May 2015 04:56:17 +0200
> Subject: [PATCH 3/3] website: Fix URLs.
[...]
> - (a (@ (href "http://www.gnu.org/philosophy/free-sw.html")
> + (a (@ (href "https://www.gnu.org/philosophy/free-sw.html")
I think this should be (gnu-url "philosophy/free-sw.html"), which would
return “/philosophy/free-sw.html” by default (with a ‘gnu.org-root’
parameter object.)
> - (a (@ (href "/software/guix/download/")
> + (a (@ (href ,(url-base "/download"))
Maybe (base-url "download") would be clearer.
> + (img (@ (src ,(img-url "h-separator-darker.png"))
s/img-url/image-url/
> +(define current-url-root
> + (make-parameter "/home/mthl/src/gnu/guix-artwork/website/build"))
Rather default to “/software/guix”.
> +(define resources-url-root
> + (make-parameter "https://www.gnu.org/s/guix"))
Default to (current-url-root).
OK for me with these changes.
Thank you!
Ludo’.
next prev parent reply other threads:[~2015-05-08 10:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-08 4:09 [PATCH] website : Mathieu Lirzin
2015-05-08 10:45 ` Ludovic Courtès [this message]
2015-05-08 11:02 ` Mathieu Lirzin
2015-05-09 0:03 ` Mathieu Lirzin
2015-05-09 14:22 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87oalvl549.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
--cc=mthl@openmailbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).